You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by milleruntime <gi...@git.apache.org> on 2016/09/09 17:56:45 UTC
[GitHub] accumulo pull request #149: ACCUMULO-2972: fixed description for instance.se...
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/149
ACCUMULO-2972: fixed description for instance.secret
1.6 documentation fix for ACCUMULO-2972
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milleruntime/accumulo ACCUMULO-2972_1.6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit 2165dde60827a1b7a9dc7c4c78f8e183bc04b104
Author: milleruntime <mi...@gmail.com>
Date: 2016-09-09T17:53:51Z
ACCUMULO-2972: fixed description for instance.secret
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #149: ACCUMULO-2972: fixed description for instance.secret
Posted by milleruntime <gi...@git.apache.org>.
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/149
Made English better in 0ecc47161cc5b019f856dccd78bec48c4ba70e13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #149: ACCUMULO-2972: fixed description for instance.se...
Posted by milleruntime <gi...@git.apache.org>.
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/149#discussion_r78224771
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -123,8 +123,9 @@
@Sensitive
INSTANCE_SECRET("instance.secret", "DEFAULT", PropertyType.STRING,
"A secret unique to a given instance that all servers must know in order to communicate with one another."
- + " Change it before initialization. To change it later use ./bin/accumulo accumulo.server.util.ChangeSecret [oldpasswd] [newpasswd], "
- + " and then update conf/accumulo-site.xml everywhere."),
+ + "Change it before initialization. To change it later use the ChangeSecret tool and then update conf/accumulo-site.xml everywhere."
+ + "Before using the ChangeSecret tool, make sure Accumulo is not running and you are logged in as the user that controls Accumulo files in HDFS."
+ + "To use the ChangeSecret tool, run the command: ./bin/accumulo accumulo.server.util.ChangeSecret"),
--- End diff --
Yeah good catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #149: ACCUMULO-2972: fixed description for instance.se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #149: ACCUMULO-2972: fixed description for instance.se...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/149#discussion_r78223111
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -123,8 +123,9 @@
@Sensitive
INSTANCE_SECRET("instance.secret", "DEFAULT", PropertyType.STRING,
"A secret unique to a given instance that all servers must know in order to communicate with one another."
- + " Change it before initialization. To change it later use ./bin/accumulo accumulo.server.util.ChangeSecret [oldpasswd] [newpasswd], "
- + " and then update conf/accumulo-site.xml everywhere."),
+ + "Change it before initialization. To change it later use the ChangeSecret tool and then update conf/accumulo-site.xml everywhere."
+ + "Before using the ChangeSecret tool, make sure Accumulo is not running and you are logged in as the user that controls Accumulo files in HDFS."
+ + "To use the ChangeSecret tool, run the command: ./bin/accumulo accumulo.server.util.ChangeSecret"),
--- End diff --
package name is incorrect here. can probably fix that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #149: ACCUMULO-2972: fixed description for instance.se...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/149#discussion_r78223626
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -123,8 +123,9 @@
@Sensitive
INSTANCE_SECRET("instance.secret", "DEFAULT", PropertyType.STRING,
"A secret unique to a given instance that all servers must know in order to communicate with one another."
- + " Change it before initialization. To change it later use ./bin/accumulo accumulo.server.util.ChangeSecret [oldpasswd] [newpasswd], "
- + " and then update conf/accumulo-site.xml everywhere."),
+ + "Change it before initialization. To change it later use the ChangeSecret tool and then update conf/accumulo-site.xml everywhere."
--- End diff --
maybe `s/Change it before initialization/It should be changed prior to initializing Accumulo/` ?
[nits] `s/later use/later, use/`, `s/and then/and/`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---