You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Stefan Groschupf (JIRA)" <ji...@apache.org> on 2008/02/26 03:03:51 UTC
[jira] Created: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
--------------------------------------------------------------------------------------------
Key: PIG-122
URL: https://issues.apache.org/jira/browse/PIG-122
Project: Pig
Issue Type: Improvement
Reporter: Stefan Groschupf
This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Groschupf updated PIG-122:
---------------------------------
Attachment: PIG-122_v_1.patch
> remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
> --------------------------------------------------------------------------------------------
>
> Key: PIG-122
> URL: https://issues.apache.org/jira/browse/PIG-122
> Project: Pig
> Issue Type: Improvement
> Reporter: Stefan Groschupf
> Attachments: PIG-122_v_1.patch
>
>
> This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
> Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-122:
---------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
The original generated .java files listed in this issue have already been moved to src-gen and so are no longer an issue. But I did check in the changes to the top level directory that added build and src-gen to the list of objects to be ignored. Thanks Stefan for the patch.
> remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
> --------------------------------------------------------------------------------------------
>
> Key: PIG-122
> URL: https://issues.apache.org/jira/browse/PIG-122
> Project: Pig
> Issue Type: Improvement
> Reporter: Stefan Groschupf
> Attachments: PIG-122-v02.patch, PIG-122-v03.patch, PIG-122_v_1.patch
>
>
> This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
> Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573122#action_12573122 ]
Olga Natkovich commented on PIG-122:
------------------------------------
Since we reworked the build, all generated files are under src-gen which is not part of svn so I don't think we need to do anything. Am I missing something or can we close this bug?
> remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
> --------------------------------------------------------------------------------------------
>
> Key: PIG-122
> URL: https://issues.apache.org/jira/browse/PIG-122
> Project: Pig
> Issue Type: Improvement
> Reporter: Stefan Groschupf
> Attachments: PIG-122_v_1.patch
>
>
> This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
> Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Francisoud updated PIG-122:
------------------------------------
Attachment: PIG-122-v03.patch
also removing useless svn:ignore from :
* src/org/apache/pig/tools/pigscript/parser
* src/org/apache/pig/impl/logicalLayer/parser
> remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
> --------------------------------------------------------------------------------------------
>
> Key: PIG-122
> URL: https://issues.apache.org/jira/browse/PIG-122
> Project: Pig
> Issue Type: Improvement
> Reporter: Stefan Groschupf
> Attachments: PIG-122-v02.patch, PIG-122-v03.patch, PIG-122_v_1.patch
>
>
> This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
> Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573939#action_12573939 ]
Stefan Groschupf commented on PIG-122:
--------------------------------------
Right and remove the unused svn ignore in src/org/apache/pig/tools/pigscript/parser.
> remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
> --------------------------------------------------------------------------------------------
>
> Key: PIG-122
> URL: https://issues.apache.org/jira/browse/PIG-122
> Project: Pig
> Issue Type: Improvement
> Reporter: Stefan Groschupf
> Attachments: PIG-122-v02.patch, PIG-122_v_1.patch
>
>
> This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
> Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573126#action_12573126 ]
Stefan Groschupf commented on PIG-122:
--------------------------------------
try
svn propget svn:ignore src/org/apache/pig/tools/pigscript/parser within your pig folder on command line.
it shows:
TokenMgrError.java
Token.java
SimpleCharStream.java
PigScriptParserTokenManager.java
PigScriptParserConstants.java
PigScriptParser.java
ParseException.java
What basically means that is file are ignored within any svn interaction. First, we simply should clean up this, since we not need this. Users that had used the old ant script. will run into the same duplicate class problem you did run into when using the new build.xml with out ant clean with the last one.
> remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
> --------------------------------------------------------------------------------------------
>
> Key: PIG-122
> URL: https://issues.apache.org/jira/browse/PIG-122
> Project: Pig
> Issue Type: Improvement
> Reporter: Stefan Groschupf
> Attachments: PIG-122_v_1.patch
>
>
> This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
> Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-122) remove TokenMgrError and Co from svn
properties in src/org/apache/pig/tools/pigscript/parser
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Francisoud updated PIG-122:
------------------------------------
Attachment: PIG-122-v02.patch
Files are generated in src-gen now, don't they ?
I think we should svn:ignore "src-gen" and also the "build" folder
Here's a patch to update svn:ignore prop in trunk
> remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser
> --------------------------------------------------------------------------------------------
>
> Key: PIG-122
> URL: https://issues.apache.org/jira/browse/PIG-122
> Project: Pig
> Issue Type: Improvement
> Reporter: Stefan Groschupf
> Attachments: PIG-122-v02.patch, PIG-122_v_1.patch
>
>
> This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
> Also we should add src-gen to the svn:ignore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.