You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/13 19:17:33 UTC

[GitHub] [arrow] save-buffer commented on a change in pull request #12605: ARROW-15911: [C++] Find correct GTest on macOS with Xcode

save-buffer commented on a change in pull request #12605:
URL: https://github.com/apache/arrow/pull/12605#discussion_r825491934



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1844,10 +1844,14 @@ macro(build_gtest)
   set(GTEST_VENDORED TRUE)
   set(GTEST_CMAKE_CXX_FLAGS ${EP_CXX_FLAGS})
 
-  if(CMAKE_BUILD_TYPE MATCHES DEBUG)
-    set(CMAKE_GTEST_DEBUG_EXTENSION "d")
+  if(NOT CMAKE_GENERATOR STREQUAL Xcode)

Review comment:
       `GENERATOR_IS_MULTI_CONFIG` seems to work on Xcode for me, I've switched to it. @westonpace could you give it a go on Visual Studio? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org