You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Aleksey Gorshkov (JIRA)" <ji...@apache.org> on 2012/11/06 16:20:12 UTC

[jira] [Created] (YARN-204) test coverage for org.apache.hadoop.tools

Aleksey Gorshkov created YARN-204:
-------------------------------------

             Summary: test coverage for org.apache.hadoop.tools
                 Key: YARN-204
                 URL: https://issues.apache.org/jira/browse/YARN-204
             Project: Hadoop YARN
          Issue Type: Bug
          Components: applications
            Reporter: Aleksey Gorshkov


Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502698#comment-13502698 ] 

Aleksey Gorshkov commented on YARN-204:
---------------------------------------

OK. I've fixed code .
About DistCh. The code with Random data have been wrote early.  I've rewrote this code  
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Gorshkov updated YARN-204:
----------------------------------

    Attachment: YARN-204-trunk.patch
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493304#comment-13493304 ] 

Robert Joseph Evans commented on YARN-204:
------------------------------------------

Both of those tests seem to be failing in trunk right now anyways.  they were not caused by your patches.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Gorshkov updated YARN-204:
----------------------------------

    Attachment:     (was: YARN-204-trunk.patch)
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491752#comment-13491752 ] 

Hadoop QA commented on YARN-204:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12552294/YARN-204-trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-tools/hadoop-archives hadoop-tools/hadoop-distcp hadoop-tools/hadoop-extras:

                  org.apache.hadoop.tools.TestCopyListing
                  org.apache.hadoop.tools.TestCopyFiles

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/135//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/135//console

This message is automatically generated.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500412#comment-13500412 ] 

Hadoop QA commented on YARN-204:
--------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12554163/YARN-204-trunk-a.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-tools/hadoop-archives hadoop-tools/hadoop-distcp hadoop-tools/hadoop-extras.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/159//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/159//console

This message is automatically generated.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504674#comment-13504674 ] 

Hadoop QA commented on YARN-204:
--------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12554664/YARN-204-trunk-b.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-tools/hadoop-archives hadoop-tools/hadoop-distcp hadoop-tools/hadoop-extras.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/162//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/162//console

This message is automatically generated.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23-b.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2-b.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk-b.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504710#comment-13504710 ] 

Robert Joseph Evans commented on YARN-204:
------------------------------------------

+1 the new changes look better. I'll check this in.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23-b.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2-b.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk-b.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505359#comment-13505359 ] 

Hudson commented on YARN-204:
-----------------------------

Integrated in Hadoop-Yarn-trunk #50 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/50/])
    YARN-204. test coverage for org.apache.hadoop.tools (Aleksey Gorshkov via bobby) (Revision 1414239)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1414239
Files : 
* /hadoop/common/trunk/hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
* /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestExternalCall.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestCopyFiles.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestLogalyzer.java
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt

                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23-b.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2-b.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk-b.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500168#comment-13500168 ] 

Aleksey Gorshkov commented on YARN-204:
---------------------------------------

YARN-204-trunk-a.patch - patch for trunk .
YARN-204-branch-2-a.patch - patch for branch-2 
YARN-204-branch-0.23-a.patch - patch for branch-0.23
OK. I've fixed  testMapCount in TestCopyFiles.  
patches ready for commit
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493122#comment-13493122 ] 

Aleksey Gorshkov commented on YARN-204:
---------------------------------------

YARN-204-trunk.patch - patch for trunk .
YARN-204-branch-2.patch - patch for branch-2 
YARN-204-branch-0.23.patch - patch for branch-0.23

                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Gorshkov updated YARN-204:
----------------------------------

    Attachment: YARN-204-trunk.patch
                YARN-204-branch-2.patch
                YARN-204-branch-0.23.patch
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated YARN-204:
-------------------------------------

    Assignee: Aleksey Gorshkov
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Gorshkov updated YARN-204:
----------------------------------

    Attachment: YARN-204-trunk-a.patch
                YARN-204-branch-2-a.patch
                YARN-204-branch-0.23-a.patch
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Gorshkov updated YARN-204:
----------------------------------

    Attachment: YARN-204-trunk.patch
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Gorshkov updated YARN-204:
----------------------------------

    Attachment: YARN-204-trunk-b.patch
                YARN-204-branch-2-b.patch
                YARN-204-branch-0.23-b.patch
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23-b.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2-b.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk-b.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493125#comment-13493125 ] 

Aleksey Gorshkov commented on YARN-204:
---------------------------------------

I do not understand why org.apache.hadoop.tools.TestCopyListing.testDuplicates is failed   
I have not changed  the org.apache.hadoop.tools.TestCopyListing . 

                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504723#comment-13504723 ] 

Hudson commented on YARN-204:
-----------------------------

Integrated in Hadoop-trunk-Commit #3061 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3061/])
    YARN-204. test coverage for org.apache.hadoop.tools (Aleksey Gorshkov via bobby) (Revision 1414239)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1414239
Files : 
* /hadoop/common/trunk/hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
* /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestExternalCall.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestCopyFiles.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestLogalyzer.java
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt

                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23-b.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2-b.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk-b.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493311#comment-13493311 ] 

Robert Joseph Evans commented on YARN-204:
------------------------------------------

Sorry I was off a bit on the last comment TestCopyFiles appears to have been a random error of some sort where the MR job did not launch.  I reran it and it passed both with your patch and without it.  TestCopyListing is failing on trunk right now and is probably not related.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498080#comment-13498080 ] 

Robert Joseph Evans commented on YARN-204:
------------------------------------------

I have one comment testMapCount in TestCopyFiles got turned into tesMapCount.  Without the t at the beginning the test is not run.  What is more this test fails with this patch and the t, but passed previously.  Please fix it.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500440#comment-13500440 ] 

Robert Joseph Evans commented on YARN-204:
------------------------------------------

I have a few more comments. Sorry to keep giving you more things to do.  These are mostly just minor cleanup things.  I am a bit confused by TestExternalCall and what exactly it is trying to test. I think I understand it, but it would be nice to have a comment in there that explains what it is intended to test.

Also inside the tests in several places in the test you catch(Exception e) and then fail the test.  I personally think it is cleaner to just let the test throw the exception and have JUnit report the "Error".

In Test DistCh you are using a Random.  I am glad that there is a way to override the seed, but I think it would be best to have a hard coded seed instead of just outputting it in the logs.

There are a few places that there is old code that is commented out.  Please just remove that code.
                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Aleksey Gorshkov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aleksey Gorshkov updated YARN-204:
----------------------------------

    Attachment:     (was: YARN-204-trunk.patch)
    
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-204-branch-0.23.patch, YARN-204-branch-2.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-204) test coverage for org.apache.hadoop.tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/YARN-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505423#comment-13505423 ] 

Hudson commented on YARN-204:
-----------------------------

Integrated in Hadoop-Hdfs-0.23-Build #449 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/449/])
    svn merge -c 1414239 FIXES: YARN-204. test coverage for org.apache.hadoop.tools (Aleksey Gorshkov via bobby) (Revision 1414243)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1414243
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-archives/src/test/java/org/apache/hadoop/tools/TestHadoopArchives.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestExternalCall.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestCopyFiles.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestDistCh.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/tools/TestLogalyzer.java
* /hadoop/common/branches/branch-0.23/hadoop-yarn-project/CHANGES.txt

                
> test coverage for org.apache.hadoop.tools
> -----------------------------------------
>
>                 Key: YARN-204
>                 URL: https://issues.apache.org/jira/browse/YARN-204
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>            Reporter: Aleksey Gorshkov
>            Assignee: Aleksey Gorshkov
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.6
>
>         Attachments: YARN-204-branch-0.23-a.patch, YARN-204-branch-0.23-b.patch, YARN-204-branch-0.23.patch, YARN-204-branch-2-a.patch, YARN-204-branch-2-b.patch, YARN-204-branch-2.patch, YARN-204-trunk-a.patch, YARN-204-trunk-b.patch, YARN-204-trunk.patch
>
>
> Added some tests for org.apache.hadoop.tools

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira