[GitHub] [spark] srowen commented on a change in pull request #24219: [SPARK-27258][K8S] The first character of Service's name is digit, which does not match regular expression [a-z]([-a-z0-9]*[a-z0-9])?)

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24219: [SPARK-27258][K8S] The first character of  Service's name is digit,which  does not match regular expression [a-z]([-a-z0-9]*[a-z0-9])?)
URL: https://github.com/apache/spark/pull/24219#discussion_r269064949
 
 

 ##########
 File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStep.scala
 ##########
 @@ -38,15 +38,21 @@ private[spark] class DriverServiceFeatureStep(
     s"$DRIVER_HOST_KEY is not supported in Kubernetes mode, as the driver's hostname will be " +
       "managed via a Kubernetes service.")
 
+  def isDigit(char: Char) : Boolean = {
+    char >= '0' && char <= '9'
+  }
+
   private val preferredServiceName = s"${kubernetesConf.resourceNamePrefix}$DRIVER_SVC_POSTFIX"
-  private val resolvedServiceName = if (preferredServiceName.length <= MAX_SERVICE_NAME_LENGTH) {
+  private val resolvedServiceName = if (preferredServiceName.length <= MAX_SERVICE_NAME_LENGTH
+    && !isDigit(preferredServiceName.charAt(0))) {
 
 Review comment:
   This is still wrong. You are saying the first character needs to be a-z. This only checks if it's a digit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org