[jira] [Commented] (HADOOP-12974) Create a CachingGetSpaceUsed implementation that uses df

["Wei-Chiu Chuang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292142#comment-15292142 ] 

Wei-Chiu Chuang commented on HADOOP-12974:
------------------------------------------

Thanks [~eclark] for the patch!
I quickly went over the v3 patch, and it is looks good to me. A few minor issues:

# do not use wildcard import 
{code}
import static org.junit.Assert.*;
{code}

# in the test {{TestDFCachingGetSpaceUsed#testCanBuildRun}}, I don't think you need to typecast the instance object.
{code}
((DFCachingGetSpaceUsed)instance).close();
{code}


> Create a CachingGetSpaceUsed implementation that uses df
> --------------------------------------------------------
>
>                 Key: HADOOP-12974
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12974
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 2.9.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HADOOP-12974v0.patch, HADOOP-12974v1.patch, HADOOP-12974v2.patch, HADOOP-12974v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org