You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kiranchavala (via GitHub)" <gi...@apache.org> on 2023/07/20 08:40:50 UTC

[GitHub] [cloudstack] kiranchavala opened a new issue, #7759: UI: Customer role (rules) listVirtualMachines is not enforced

kiranchavala opened a new issue, #7759:
URL: https://github.com/apache/cloudstack/issues/7759

   **ISSUE TYPE**
   
    * BUG
   
   
   **COMPONENT NAME**
   
   Component: API, UI 
   
   
   **CLOUDSTACK VERSION**
   
   Cloudstack 4.18
   
   **SUMMARY**
   
   UI: Customer role (rules) listVirtualMachines is not enforced
   
   **Steps to reproduce the issue** 
   
   1. Create a account with the default role (user) 
   
   screenshot 
   
   ![add account (default-user role)](https://github.com/apache/cloudstack/assets/1401014/5b056408-4a50-4232-b816-badcfb048dee)
   
   
   
   2. Create a custom role 
   
   
   screenshot 
   ![custom role](https://github.com/apache/cloudstack/assets/1401014/e8a5ed57-fe8f-4e8f-bd0a-ba384a7eb7ff)
   
   
   3. Login with the normal user account  and deploy a vm 
   
   
   4. With admin user credentials  change the account role from user to custom role 
   
   (cmk) > update account roleid=e2251d81-7e2b-4f1b-bcd0-e404de8426ce  account=kiran domainid=489f928d-26c7-11ee-b6ac-1e00a8000339
   
   
   
   5.  With admin user crdentials  Modify the rules in custom role ( for example  Deny )
   
   screenshot
   ![update rules](https://github.com/apache/cloudstack/assets/1401014/4b57ee71-ce9f-40dc-9db0-af3bbd284b19)
   
   
   For example : 
   
   I have updated the listvirtualmachine permission to deny for the custom-role
   
   (cmk) > update rolepermission roleid=e2251d81-7e2b-4f1b-bcd0-e404de8426ce ruleid=1c55b696-0f22-4302-93fe-da44aadcf282 permission=deny
   {
     "success": true
   }
   
   
   5. With normal user credentials Execute the list virtual machines 
   
   Expected behaviour
   
   (cmk) > list virtualmachines
    Error: (HTTP 432, error code 9999) The API [listVirtualMachines] does not exist or is not available for the account Account [{"accountName":"kiran","id":5,"uuid":"25753675-308f-4c19-b659-51482966201a"}
   
   
   6. Login to the Ui with ( normal user)
   
   ![normal user1](https://github.com/apache/cloudstack/assets/1401014/4642101f-d720-4721-b632-c4fd9e7e5efb)
   
   ![normal user2](https://github.com/apache/cloudstack/assets/1401014/1078195d-86a2-47af-91cb-f552b00080a0)
   
   
   Able to see the virtual machines 
   
   
   
   **Actual behavior** 
   
   Normal user is able to see the virtual machines , even though the listVirtualMachines api is not working
   
   
   
   
   **Expected behavior** 
   
   Normal user should not be able to see the virtual machines as the listVirtualMachines api is not working
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] mlsorensen commented on issue #7759: UI: Custom-role (rules) listVirtualMachines is not enforced

Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on issue #7759:
URL: https://github.com/apache/cloudstack/issues/7759#issuecomment-1644892993

   @kiranchavala - from what I can tell, this is because your role doesn't have a deny all at the end. The UI doesn't use `listVirtualMachines` API to generate this page. It uses `listVirtualMachinesMetrics` API.
   
   One solution could be to deny `listVirtualMachines*` in your role. Or add a Deny `*` at the end (which would block all API calls not listed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala commented on issue #7759: UI: Custom-role (rules) listVirtualMachines is not enforced

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on issue #7759:
URL: https://github.com/apache/cloudstack/issues/7759#issuecomment-1644998926

   @mlsorensen thanks Adding a deny rule for listVirtualMachinesMetrics solved the issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] kiranchavala closed issue #7759: UI: Custom-role (rules) listVirtualMachines is not enforced

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala closed issue #7759: UI: Custom-role (rules) listVirtualMachines is not enforced
URL: https://github.com/apache/cloudstack/issues/7759


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org