You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2021/12/08 19:17:21 UTC
[camel] branch main updated: camel-management - A mbean was using getXXX name for JMX operations which is not good practice.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 9daba96 camel-management - A mbean was using getXXX name for JMX operations which is not good practice.
9daba96 is described below
commit 9daba96b35c2306190cf403c3ca9e8c3edff5e10
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Wed Dec 8 20:16:38 2021 +0100
camel-management - A mbean was using getXXX name for JMX operations which is not good practice.
---
.../api/management/mbean/ManagedBacklogDebuggerMBean.java | 14 ++++++++++++++
.../camel/management/mbean/ManagedBacklogDebugger.java | 10 ++++++++++
2 files changed, 24 insertions(+)
diff --git a/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java b/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
index 1e192c5..75c4df1 100644
--- a/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
+++ b/core/camel-management-api/src/main/java/org/apache/camel/api/management/mbean/ManagedBacklogDebuggerMBean.java
@@ -89,12 +89,26 @@ public interface ManagedBacklogDebuggerMBean {
@ManagedOperation(description = "Steps to next node in step mode")
void step();
+ /**
+ * @deprecated use {@link #breakpoints()}
+ */
@ManagedOperation(description = "Return the node ids which has breakpoints")
+ @Deprecated
Set<String> getBreakpoints();
+ @ManagedOperation(description = "Return the node ids which has breakpoints")
+ Set<String> breakpoints();
+
+ /**
+ * @deprecated use {@link #suspendedBreakpointNodeIds()}
+ */
@ManagedOperation(description = "Return the node ids which is currently suspended")
+ @Deprecated
Set<String> getSuspendedBreakpointNodeIds();
+ @ManagedOperation(description = "Return the node ids which is currently suspended")
+ Set<String> suspendedBreakpointNodeIds();
+
@ManagedOperation(description = "Disables a breakpoint")
void disableBreakpoint(String nodeId);
diff --git a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
index cb3ac35..9554cd8 100644
--- a/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
+++ b/core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedBacklogDebugger.java
@@ -107,6 +107,11 @@ public class ManagedBacklogDebugger implements ManagedBacklogDebuggerMBean {
@Override
public Set<String> getBreakpoints() {
+ return breakpoints();
+ }
+
+ @Override
+ public Set<String> breakpoints() {
return backlogDebugger.getBreakpoints();
}
@@ -181,6 +186,11 @@ public class ManagedBacklogDebugger implements ManagedBacklogDebuggerMBean {
@Override
public Set<String> getSuspendedBreakpointNodeIds() {
+ return suspendedBreakpointNodeIds();
+ }
+
+ @Override
+ public Set<String> suspendedBreakpointNodeIds() {
return backlogDebugger.getSuspendedBreakpointNodeIds();
}