You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/28 14:06:00 UTC

[GitHub] [geode-native] gaussianrecurrence edited a comment on pull request #680: GEODE-8666: Enforce no-non-virtual-dtor

gaussianrecurrence edited a comment on pull request #680:
URL: https://github.com/apache/geode-native/pull/680#issuecomment-717956010


   I am running an [ABI compliance tool](https://lvc.github.io/abi-compliance-checker/) having compiled both the develop branch and the PR's branch and oddly it states that changes introduced are ABI backward compatible. I will try to run the same check with Clang-6.0 and onwards so as well as win MSVC.
   
   As stated by @pivotal-jbarrett, exposing base class destructors into vtable should be an ABI breaking change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org