You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/08/23 07:00:17 UTC
[GitHub] zeppelin pull request #1354: [ZEPPELIN-1346] Add contribution guidelines to ...
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1354
[ZEPPELIN-1346] Add contribution guidelines to the website
### What is this PR for?
This PR is bringing Contribution guidelines to the website.
We also introduce a sidemenu on those pages allowing to create additional content.
As an example, for the Web Application Guidelines, we added a page about "Defining Components"
In a different PR, we will remove the contributing markdown, and change the links in the repository to the website.
### What type of PR is it?
Documentation
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1346
### How should this be tested?
Build the website locally and visit the community page
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin add/ContributeCategory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1354
----
commit 06238fbc9b3a65085db2ea1ad4aa53630b1660f3
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-22T04:47:46Z
Modify the Community page
commit cb8760861b28b78e2ffc58e65bafd1ee154ce30b
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-22T04:51:45Z
Add forgotten license headers
commit acc68b50d71e16752eb598235d5be32ad6fbf5b8
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-22T05:38:19Z
Add contribution Guidelines to the website
commit 5f7e2bd47c2b027c9d63fb4d0ebc6c9e2b8b2e33
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-22T08:13:14Z
Add a side menu template
commit c933c194b3190961e799b8c9a75071718290c6dd
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-22T08:43:34Z
Add zeppelin-web contribution page
commit 306ae06724a870b2da454283afc851f20b65925f
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-22T09:05:32Z
Add zeppelin-web GPG menu
commit 666f3ec95ed4f7d6aed5efefec3b40269d022bf0
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-23T05:31:29Z
Add first Zeppelin-web best practices page
commit 81493abd9ecbf07cf864f5509e96c1bbabdc72ce
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-23T06:45:29Z
Change Side Menu style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1354: [ZEPPELIN-1346] Add contribution guidelines to the web...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1354
@bzz I added a section with the Selenium CLI command, can you double check it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1354: [ZEPPELIN-1346] Add contribution guidelines to the web...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1354
@AhyoungRyu That's the goal of having the side menu, to be able to have contribution guide focused on specific components (Back-end, front-end, interpreters, website, docs etc..)
I only wanted to cover the structure in this PR, that's why there is web application as example.
So you can either do a PR after this one is merged, or directly in this PR, your choice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1354: [ZEPPELIN-1346] Add contribution guidelines to the web...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1354
@corneadoug Thank you for the explanation. Since it's a only one page, i've created a PR at your repo :)
(Just combined `docs/README.md` & `docs/CONTRIBUTING.md` contents)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1354: [ZEPPELIN-1346] Add contribution guidelines to the web...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1354
@corneadoug Great work! Definitely this way would be better than we put `CONTRIBUTING.md` under each component dir in Zeppelin github. I also left some minor comments.
One question. If this PR can cover the other contributing guide(not only `web application`), can we put `docs/CONTRIBUTING.md` as well? What do you think? I can create a PR to your repo for that if you're positive :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1354: [ZEPPELIN-1346] Add contribution guidelines to ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1354: [ZEPPELIN-1346] Add contribution guidelines to the web...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1354
Overall looks great to me, thank you @corneadoug for taking care! Few minor comments above.
\cc @AhyoungRyu for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1354: [ZEPPELIN-1346] Add contribution guidelines to the web...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1354
All the changes have been addressed. LGTM?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1354: [ZEPPELIN-1346] Add contribution guidelines to the web...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1354
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---