You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mehdid93 (via GitHub)" <gi...@apache.org> on 2024/11/20 09:58:07 UTC
[PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
mehdid93 opened a new pull request, #25670:
URL: https://github.com/apache/flink/pull/25670
Contribute-to: https://issues.apache.org/jira/browse/FLINK-36739
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request raises the version of the NodeJS module which is a pre-requisite to upgrade dependencies in order to address vulnerabilities in Runtime/WebFrontend component.
There will be another PR to fix vulnerabilities once this is merged.
## Brief change log
NodeJS is v22.11.0/Npm is 10.9.0
## Verifying this change
The Flink UI should be accessible without any difference
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "simplejason (via GitHub)" <gi...@apache.org>.
simplejason commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2510619570
Glad to see the front-end version upgrades is concerned, I'm trying to upgrade `ng-zorro-antd` and `angular` to v18 and having the same problem regarding `GLIBC 2.28`(#25713).
I think we need to upgrade the containers(maybe only Ubuntu?) in flink-2.0 to make it work :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "mehdid93 (via GitHub)" <gi...@apache.org>.
mehdid93 commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2501347397
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "mehdid93 (via GitHub)" <gi...@apache.org>.
mehdid93 commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2504432014
@zentol Thank you! I have pushed a commit to use the new Image in order to test the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "mehdid93 (via GitHub)" <gi...@apache.org>.
mehdid93 commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2505664022
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2488701144
@mehdid93 when you say "There will be another PR to fix vulnerabilities once this is merged.". Can you confirm that this PR does not introduce any vulnerabilities compared to the older version please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2488136503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c7c73f9f60c35c64700e47eaa21b1a6e4f041aff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7c73f9f60c35c64700e47eaa21b1a6e4f041aff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7c73f9f60c35c64700e47eaa21b1a6e4f041aff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "mehdid93 (via GitHub)" <gi...@apache.org>.
mehdid93 commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2503685364
> We can't change the CI flows to work on a container from a non-PMC member unfortunately. Let me check this with the other PMCs on how to unblock you
Sorry about that @MartijnVisser and @zentol I've revert the last commit and thank you for your help @zentol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2508047753
@MartijnVisser I approved this one too early - prior to the CI change going in. Going forward I will only approve when there is a successful CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "mehdid93 (via GitHub)" <gi...@apache.org>.
mehdid93 commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2506492367
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "mehdid93 (via GitHub)" <gi...@apache.org>.
mehdid93 commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2507922031
> @mehdid93 Can you please rebase, and make sure that you have one commit with the actual change?
Yes I have rebased and squashed my commits should be okay now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #25670:
URL: https://github.com/apache/flink/pull/25670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2490393427
Reviewed by Chi on 21/11/24. Asked submitter questions
@mehdid93 Looks good - but why are the CI tests failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2503299977
> why are the CI tests failing?
Because the image was modified incorrectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #25670:
URL: https://github.com/apache/flink/pull/25670#issuecomment-2504396199
@mehdid93 You can try your changes with [chesnay/flink-ci:java_8_11_17_21_maven_386_jammy](https://hub.docker.com/layers/chesnay/flink-ci/java_8_11_17_21_maven_386_jammy/images/sha256-85838a97ac7151fac2493de5df7dd8fbb02e3ba1d48d7f64b654866deed07448?context=explore).
I'll open a PR tomorrow to update CI as a whole to use that image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org