[jira] [Commented] (FLINK-9305) Register flink-s3-fs-hadoop for the s3a:// scheme as well

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465876#comment-16465876 ] 

ASF GitHub Bot commented on FLINK-9305:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5963

    [FLINK-9305][s3] also register flink-s3-fs-hadoop's factory for the s3a:// scheme

    ## What is the purpose of the change
    
    For enhanced user experience, we should also register our Hadoop S3A-based shaded S3 file system implementation for the `s3a://` file system scheme, not just `s3://`(similar to supporting fall-back configuration options which are already supported). This way, the user can easily switch from the manual S3 integration to the shaded one.
    
    ## Brief change log
    
    - create a separate `S3AFileSystemFactory` deriving from `S3FileSystemFactory` with a different scheme onle
    - add `S3AFileSystemFactory` to the service file
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - made existing tests parameterized for using both schemes: `s3://` and `s3a://` (except `HadoopS3FileSystemBehaviorITCase` which takes a lot of time and would just test the same implementation again without any difference)
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **yes**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **docs**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-9305

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5963.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5963
    
----
commit 796c43a4638a6c7d49cfebeaaa9fe1c2c9f247d7
Author: Nico Kruber <ni...@...>
Date:   2018-05-07T10:02:38Z

    [hotfix][docs] fix flink-s3-fs-* README entry for the service file

commit 26f03124f566473423cb5f356380918399f9010b
Author: Nico Kruber <ni...@...>
Date:   2018-05-07T12:31:47Z

    [hotfix][s3][tests] port config key forwarding test from hadoop S3 to presto

commit 5b6e8f8a92ad13d8d95394e0454b599a53ad1d1b
Author: Nico Kruber <ni...@...>
Date:   2018-05-07T10:03:15Z

    [FLINK-9305][s3] also register flink-s3-fs-hadoop's factory for the s3a:// scheme

----


> Register flink-s3-fs-hadoop for the s3a:// scheme as well
> ---------------------------------------------------------
>
>                 Key: FLINK-9305
>                 URL: https://issues.apache.org/jira/browse/FLINK-9305
>             Project: Flink
>          Issue Type: Improvement
>          Components: filesystem-connector
>    Affects Versions: 1.4.0, 1.5.0, 1.4.1, 1.4.2, 1.6.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>
> For enhanced user experience, we should also register our Hadoop S3A-based shaded S3 file system implementation for the {{s3a://}} file system scheme, not just {{s3://}}. This way, the user can easily switch from the manual S3 integration to the shaded one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)