You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2023/08/21 19:08:00 UTC

[jira] [Updated] (CASSANDRA-18783) CEP-15 (C*): when loading commands that have empty waiting_on, make sure not to loose the partial deps

     [ https://issues.apache.org/jira/browse/CASSANDRA-18783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Capwell updated CASSANDRA-18783:
--------------------------------------
     Bug Category: Parent values: Correctness(12982)Level 1 values: Unrecoverable Corruption / Loss(13161)
       Complexity: Low Hanging Fruit
    Discovered By: Performance Regression Test
    Fix Version/s: 5.x
         Severity: Critical
           Status: Open  (was: Triage Needed)

> CEP-15 (C*): when loading commands that have empty waiting_on, make sure not to loose the partial deps
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18783
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18783
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Accord
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 5.x
>
>
> This was found in benchmark clusters
> {code}
> java.lang.IllegalStateException: Deps do not match; expected {}, {} == [tlp_stress:[(-1182483594468561006,-472993437787424406]]]:{tlp_stress:DecoratedKey(-1000036068852656106, 3030312e302e35383730313035):[[17,1692599889087003,0,1]]}, {}
> 	accord.utils.Invariants.illegalState(Invariants.java:44)
> 	accord.utils.Invariants.checkState(Invariants.java:133)
> 	accord.local.Command$Committed.<init>(Command.java:826)
> 	accord.local.Command$Committed.<init>(Command.java:817)
> 	accord.local.Command$Executed.<init>(Command.java:905)
> 	accord.local.Command$Executed.executed(Command.java:951)
> 	accord.local.Command$SerializerSupport.executed(Command.java:165)
> 	org.apache.cassandra.service.accord.AccordKeyspace.loadCommand(AccordKeyspace.java:1197)
> {code}
> The root cause is that “empty” waiting_on drops the partial deps when we write/load but this becomes an issue for Command.Committed as it double checks partial_deps == waiting_on.deps



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org