You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ssjssh <gi...@git.apache.org> on 2014/10/15 16:35:31 UTC

[GitHub] spark pull request: improve spark on yarn doc(issus 3629 on jira)

GitHub user ssjssh opened a pull request:

    https://github.com/apache/spark/pull/2813

    improve spark on yarn doc(issus 3629 on jira)

    Right now  running-on-yarn.md starts off with a big list of config options, and only then tells you how to submit an app. It would be better to put that part and the packaging part first, and the config options only at the end. Besides I add some explainations about yarn-cluster and yarn-client mode 
    
    https://issues.apache.org/jira/browse/SPARK-3629

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssjssh/spark improve-spark-on-yarn-doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2813.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2813
    
----
commit f8ec44d3304c2c28c176257e6a75102c655ee71d
Author: ssjssh <ss...@163.com>
Date:   2014-10-08T15:30:13Z

    use test to explore spark

commit 25a3c127cff84a61cf31ecfdefed9b83cc18dc19
Author: ssjssh <ss...@163.com>
Date:   2014-10-08T15:38:11Z

    add first test

commit c86112f82e5cdca7629906dd2846d48149183556
Author: ssjssh <ss...@163.com>
Date:   2014-10-13T06:14:36Z

    删own文件夹

commit 92e28e1dcc08db2670b83cba5d3fae4e588644f6
Author: ssjssh <ss...@163.com>
Date:   2014-10-15T14:25:08Z

    edited to tell how to submit Spark application on yarn first and then follows the config options when works with yarn. In addition, add some explainations about yarn-cluster mode and yarn-client mode.

commit 505a155f4cd52d641a4f87822f5bfcf205a58baf
Author: ssjssh <ss...@163.com>
Date:   2014-10-15T14:29:03Z

    delete test file

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-76091536
  
    If this isn't going to be rebased and split up, do you mind closing this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/2813


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-68029649
  
    I _do_ think that it would be helpful to re-arrange this page so the high-level "here's how to run on YARN" comes before the big configuration table (I've spoken with a couple of users who would prefer that to the current page).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-62561708
  
    @ssjssh could you possibly make the changes suggested?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: improve spark on yarn doc(issus 3629 on jira)

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-59215162
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-60395462
  
    It's not possible to see what text you changed since the text was also moved. I am not sure it helps to move the text. Is it possible to see your changes in place? You could create a 'table of contents' of links at the top instead. Don't worry about 'verifying the patch' yet; Jenkins won't test until you're whitelisted but there is nothing to unit test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-70701042
  
    @ssjssh would you have time to work on this, if not can we close this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by ssjssh <gi...@git.apache.org>.
Github user ssjssh commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-59359408
  
    can someone verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-60014107
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-72534368
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-3629][Doc] improve spark on yarn doc

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/2813#issuecomment-68045956
  
    @ssjssh could you reorganize your PR to 2 commits: one for the addition or modification, the other for moving the text.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org