You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/13 15:06:15 UTC
[GitHub] [incubator-apisix] weihai4099 opened a new pull request #1047: add
yarn install instructions
weihai4099 opened a new pull request #1047: add yarn install instructions
URL: https://github.com/apache/incubator-apisix/pull/1047
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
### Summary
SUMMARY_HERE
### Full changelog
* [Implement ...]
* [Add related tests]
* ...
### Issues resolved
Fix #XXX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] weihai4099 commented on a change in pull request
#1047: add yarn install instructions
Posted by GitBox <gi...@apache.org>.
weihai4099 commented on a change in pull request #1047: add yarn install instructions
URL: https://github.com/apache/incubator-apisix/pull/1047#discussion_r366106035
##########
File path: README_CN.md
##########
@@ -143,7 +143,7 @@ APISIX 内置了对 Dashboard 的支持，使用步骤如下：
```
git clone https://github.com/apache/incubator-apisix-dashboard.git
```
-
+- 安装yarn: 参考[安装文档](https://yarnpkg.com/zh-Hans/docs/install#windows-stable)
Review comment:
Thank you. Please check again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1047: add yarn
install instructions
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1047: add yarn install instructions
URL: https://github.com/apache/incubator-apisix/pull/1047#issuecomment-573951000
@weihai4099 We also need to update the English doc.
https://github.com/apache/incubator-apisix/blob/master/README.md#dashboard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] weihai4099 commented on issue #1047: add yarn
install instructions
Posted by GitBox <gi...@apache.org>.
weihai4099 commented on issue #1047: add yarn install instructions
URL: https://github.com/apache/incubator-apisix/pull/1047#issuecomment-573958740
everything all right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis merged pull request #1047: add yarn
install instructions
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1047: add yarn install instructions
URL: https://github.com/apache/incubator-apisix/pull/1047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1047: add yarn install instructions
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1047: add yarn install instructions
URL: https://github.com/apache/incubator-apisix/pull/1047#discussion_r366097827
##########
File path: README_CN.md
##########
@@ -143,7 +143,7 @@ APISIX 内置了对 Dashboard 的支持，使用步骤如下：
```
git clone https://github.com/apache/incubator-apisix-dashboard.git
```
-
+- 安装yarn: 参考[安装文档](https://yarnpkg.com/zh-Hans/docs/install#windows-stable)
Review comment:
default link: `https://yarnpkg.com/zh-Hans/docs/install`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services