Re: [PR] chore(lint): convert class components to function components [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #37902:
URL: https://github.com/apache/superset/pull/37902#issuecomment-4269887975

   Thanks for the thorough testing @geido! A few notes on the findings:
   
   - **Parallel Coordinates label color in dark mode** — this file isn't touched by this PR, so that one's almost certainly pre-existing and unrelated.
   - **% Rural JSON parse error** and **Country of Citizenship filter** — these *could* be related since `ChartRenderer.tsx` and `FilterScopeSelector.tsx` are both converted here. Before I dig into the root cause, could you verify whether either of those reproduces on master? That'll help isolate whether they're regressions from this PR or pre-existing issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org