You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/01/23 06:13:13 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request #464:
GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are
leaked, causing Tomcat to fail to shutdown.
mike-jumper opened a new pull request #464: GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are leaked, causing Tomcat to fail to shutdown.
URL: https://github.com/apache/guacamole-client/pull/464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman merged pull request #464:
GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are
leaked, causing Tomcat to fail to shutdown.
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #464: GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are leaked, causing Tomcat to fail to shutdown.
URL: https://github.com/apache/guacamole-client/pull/464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #464:
GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are
leaked, causing Tomcat to fail to shutdown.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #464: GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are leaked, causing Tomcat to fail to shutdown.
URL: https://github.com/apache/guacamole-client/pull/464#issuecomment-577902512
Yep, `ldapConnection` is used only directly within the functions that it's passed to. It's not cached or stored for future use. Once it about to go out of scope here, it's a leak unless it's disconnected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #464:
GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are
leaked, causing Tomcat to fail to shutdown.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #464: GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are leaked, causing Tomcat to fail to shutdown.
URL: https://github.com/apache/guacamole-client/pull/464#issuecomment-577852253
Yes, and it does work. I think I remember the case you describe, and I believe that was a different function like `bindAs()` where the connection is used later.
Here, I think that `ldapConnection` is no longer used once it leaves scope. I'l recheck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] necouchman commented on issue #464:
GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are
leaked, causing Tomcat to fail to shutdown.
Posted by GitBox <gi...@apache.org>.
necouchman commented on issue #464: GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are leaked, causing Tomcat to fail to shutdown.
URL: https://github.com/apache/guacamole-client/pull/464#issuecomment-578019436
Sounds good. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services