You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by rmkellogg <gi...@git.apache.org> on 2015/08/29 13:26:29 UTC

[GitHub] storm pull request: [STORM-1019] Added missing version info to mak...

GitHub user rmkellogg opened a pull request:

    https://github.com/apache/storm/pull/710

    [STORM-1019] Added missing version info to make-maven-plugin

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmkellogg/storm MAKEPLUGIN

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/710.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #710
    
----
commit 008ed44947d7fd58adf33c5e2420829ced4bc5bf
Author: Rick Kellogg <rm...@comcast.net>
Date:   2015-08-29T03:37:20Z

    Javadoc - document exception handling on Fields & ITuple.

commit 11f41ce15d6b3ce5be5c890b680acaadffeaac3e
Author: Rick Kellogg <rm...@comcast.net>
Date:   2015-08-29T11:23:57Z

    [STORM-1019] - Added missing plugin version information.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1019][STORM-1020] Added missing version...

Posted by rmkellogg <gi...@git.apache.org>.
Github user rmkellogg commented on the pull request:

    https://github.com/apache/storm/pull/710#issuecomment-137296720
  
    Can we merge this?  No idea why Travis-CI is failing.  It worked earlier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1019][STORM-1020] Added missing version...

Posted by rmkellogg <gi...@git.apache.org>.
Github user rmkellogg closed the pull request at:

    https://github.com/apache/storm/pull/710


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1019] Added missing version info to mak...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/710#issuecomment-136023545
  
    +1. Can you fix the title of the JIRA as the pr contains doc fixes as well and minor whitespace issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1019][STORM-1020] Added missing version...

Posted by rmkellogg <gi...@git.apache.org>.
Github user rmkellogg commented on the pull request:

    https://github.com/apache/storm/pull/710#issuecomment-137850835
  
    Pull into distinct PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1019] Added missing version info to mak...

Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/710#discussion_r38264777
  
    --- Diff: storm-core/pom.xml ---
    @@ -849,6 +849,7 @@
                         <plugin>
                             <groupId>org.codehaus.mojo</groupId>
                             <artifactId>make-maven-plugin</artifactId>
    +						<version>1.0-beta-1</version>
    --- End diff --
    
    not indented


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1019] Added missing version info to mak...

Posted by rmkellogg <gi...@git.apache.org>.
Github user rmkellogg commented on the pull request:

    https://github.com/apache/storm/pull/710#issuecomment-136025230
  
    Sorry I had meant this as two distinct pull requests: STORM-1019 and STORM-1020.
    
    Whitespace change was made simply to force Travis-CI to attempt rebuild.  It fails for odd reasons yesterday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---