You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/10 01:22:52 UTC
[GitHub] [dolphinscheduler] fhygh opened a new issue, #10392: [Bug] [SQL] SQL Task Node Custom Parameters failed
fhygh opened a new issue, #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when i using Custom Parameters of SQL Task Node with OUT type, sql query result is more than one row, in downstream sql using the parameters failed, if upstream sql result is one row, it work fine.
failed work flow:
work flow success
### What you expected to happen
SQL Task Custom parameters work fine
### How to reproduce
add two sql task node, in first node query select and add custom parameter OUT type, in donwstream sql using the parameters
### Anything else
_No response_
### Version
3.0.0-beta-1
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] stalary commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
stalary commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1203562166
I will modify ParameterUtils.setInParameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liu-lewis commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
liu-lewis commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1198820918
It looks like that SqlTask missed of processing parameters with type DataType.LIST
could we resolve this issue together？@stalary @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1202504245
> It looks like that SqlTask missed of processing parameters with type DataType.LIST
> could we resolve this issue together？@stalary @zhongjiajie
You can do with @stalary if he do not mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] stalary commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
stalary commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1163201645
I can try to solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] stalary commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
stalary commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1203561351
Sql Params are replaced sql , parameters:["x1","x2"](LIST), I think we should replace [] to ()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fhygh commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters failed
Posted by GitBox <gi...@apache.org>.
fhygh commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1151801945
here is the log:
`
[LOG-PATH]: /data/apache-dolphinscheduler-3.0.0-beta-1-bin/worker-server/logs/20220610/5803827748480_10-155-217.log, [HOST]: Host{address='xxxx:1234', ip='xxxx', port=1234}
[INFO] 2022-06-10 08:46:55.800 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[120] - Full sql parameters: SqlParameters{type='MYSQL', datasource=1, sql='select name from test.userinfo1 where name in (${name})', sqlType=0, sendEmail=null, displayRows=10, limit=0, segmentSeparator=, udfs='null', showType='null', connParams='null', groupId='0', title='null', preStatements=[], postStatements=[]}
[INFO] 2022-06-10 08:46:55.801 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[121] - sql type : MYSQL, datasource : 1, sql : select name from test.userinfo1 where name in (${name}) , localParams : [],udfs : null,showType : null,connParams : null,varPool : [Property{prop='name', direct=IN, type=LIST, value='["lisi","zhangsan"]'}] ,query max result limit 0
[INFO] 2022-06-10 08:46:55.802 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[91] - setSqlParamsMap: Property with paramName: name put in sqlParamsMap of content
select name from test.userinfo1 where name in (${name}) successfully.
[INFO] 2022-06-10 08:46:55.802 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[387] - after replace sql , preparing :
select name from test.userinfo1 where name in (?)
[INFO] 2022-06-10 08:46:55.802 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[396] - Sql Params are replaced sql , parameters:["lisi","zhangsan"](LIST)
[INFO] 2022-06-10 08:46:55.802 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[465] - can't find udf function resource
[INFO] 2022-06-10 08:46:55.804 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[369] - prepare statement replace sql : HikariProxyPreparedStatement@1139720980 wrapping com.mysql.cj.jdbc.ClientPreparedStatement:
select name from test.userinfo1 where name in (** NOT SPECIFIED **)
[INFO] 2022-06-10 08:46:55.805 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[297] - main statement execute query, for sql:
select name from test.userinfo1 where name in (?)
[ERROR] 2022-06-10 08:46:55.805 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[213] - execute sql error: No value specified for parameter 1
[ERROR] 2022-06-10 08:46:55.805 +0800 [taskAppId=TASK-20220610-5803827748480_10-155-217] TaskLogLogger-class org.apache.dolphinscheduler.plugin.task.sql.SqlTask:[164] - sql task error: java.sql.SQLException: No value specified for parameter 1
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1202506626
> > Are you still work on this issue? @stalary
>
> I'm still doing it. You can do it first if you're in a hurry.
If you still doing with this, please go ahead, we may consider releases in version 3.0.1, WDTY @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] stalary commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
stalary commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1208093820
> > > It looks like that SqlTask missed of processing parameters with type DataType.LIST could we resolve this issue together？@stalary @zhongjiajie
> >
> >
> > Do you have any ideas now that I'm still in debug
>
> 1. Transform parameter of type LIST to VARCHAR；
> 2. Format sql statement with condition IN.
I have submitted the code, you can help review it~
https://github.com/apache/dolphinscheduler/pull/11285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters failed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1151795820
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1197886757
Are you still work on this issue? @stalary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] stalary commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
stalary commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1203552032
> It looks like that SqlTask missed of processing parameters with type DataType.LIST could we resolve this issue together？@stalary @zhongjiajie
Do you have any ideas now that I'm still in debug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liu-lewis commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
liu-lewis commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1208091256
> > It looks like that SqlTask missed of processing parameters with type DataType.LIST could we resolve this issue together？@stalary @zhongjiajie
>
> Do you have any ideas now that I'm still in debug
1. Transform parameter of type LIST to VARCHAR；
2. Format sql statement with condition IN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] stalary commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
stalary commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1198803931
> Are you still work on this issue? @stalary
I'm still doing it. You can do it first if you're in a hurry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #10392:
URL: https://github.com/apache/dolphinscheduler/issues/10392#issuecomment-1189874735
> I can try to solve the problem.
Hi @stalary sorry for reply late, I had assigned to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS closed issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
Posted by GitBox <gi...@apache.org>.
SbloodyS closed issue #10392: [Bug] [SQL] SQL Task Node Custom Parameters run failed
URL: https://github.com/apache/dolphinscheduler/issues/10392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org