You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/04 22:32:53 UTC

[GitHub] [beam] robertwb opened a new pull request, #17551: Better test assertion.

robertwb opened a new pull request, #17551:
URL: https://github.com/apache/beam/pull/17551

   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] angoenka merged pull request #17551: Better test assertion.

Posted by GitBox <gi...@apache.org>.
angoenka merged PR #17551:
URL: https://github.com/apache/beam/pull/17551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #17551: Better test assertion.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17551:
URL: https://github.com/apache/beam/pull/17551#issuecomment-1117995613

   R: @angoenka


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #17551: Better test assertion.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17551:
URL: https://github.com/apache/beam/pull/17551#issuecomment-1118894405

   Run Python PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on pull request #17551: Better test assertion.

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17551:
URL: https://github.com/apache/beam/pull/17551#issuecomment-1125716305

   I think this broke postcommits cc: @TheNeuralBit 
   
   ```
   E         apache_beam.runners.dataflow.dataflow_runner.DataflowRuntimeException: Dataflow pipeline failed. State: FAILED, Error:
   E         Traceback (most recent call last):
   E           File "apache_beam/runners/common.py", line 1404, in apache_beam.runners.common.DoFnRunner.process
   E           File "apache_beam/runners/common.py", line 624, in apache_beam.runners.common.SimpleInvoker.invoke_process
   E           File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python38/src/sdks/python/apache_beam/io/gcp/bigquery_json_it_test.py", line 103, in process
   E             self.assertEqual(country_expected, country_actual)
   E           File "/usr/local/lib/python3.8/unittest/case.py", line 911, in assertEqual
   E             assertion_func = self._getAssertEqualityFunc(first, second)
   E           File "/usr/local/lib/python3.8/unittest/case.py", line 892, in _getAssertEqualityFunc
   E             asserter = self._type_equality_funcs.get(type(first))
   E         AttributeError: 'CompareJson' object has no attribute '_type_equality_funcs'
   E         
   E         During handling of the above exception, another exception occurred:
   E         
   E         Traceback (most recent call last):
   E           File "/usr/local/lib/python3.8/site-packages/dataflow_worker/batchworker.py", line 646, in do_work
   E             work_executor.execute()
   E           File "/usr/local/lib/python3.8/site-packages/dataflow_worker/executor.py", line 208, in execute
   E             op.start()
   E           File "dataflow_worker/native_operations.py", line 38, in dataflow_worker.native_operations.NativeReadOperation.start
   E           File "dataflow_worker/native_operations.py", line 39, in dataflow_worker.native_operations.NativeReadOperation.start
   E           File "dataflow_worker/native_operations.py", line 44, in dataflow_worker.native_operations.NativeReadOperation.start
   E           File "dataflow_worker/native_operations.py", line 54, in dataflow_worker.native_operations.NativeReadOperation.start
   E           File "apache_beam/runners/worker/operations.py", line 514, in apache_beam.runners.worker.operations.Operation.output
   E           File "apache_beam/runners/worker/operations.py", line 226, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive
   E           File "apache_beam/runners/worker/operations.py", line 893, in apache_beam.runners.worker.operations.DoOperation.process
   E           File "apache_beam/runners/worker/operations.py", line 894, in apache_beam.runners.worker.operations.DoOperation.process
   E           File "apache_beam/runners/common.py", line 1406, in apache_beam.runners.common.DoFnRunner.process
   E           File "apache_beam/runners/common.py", line 1478, in apache_beam.runners.common.DoFnRunner._reraise_augmented
   E           File "apache_beam/runners/common.py", line 1404, in apache_beam.runners.common.DoFnRunner.process
   E           File "apache_beam/runners/common.py", line 623, in apache_beam.runners.common.SimpleInvoker.invoke_process
   E           File "apache_beam/runners/common.py", line 1585, in apache_beam.runners.common._OutputProcessor.process_outputs
   E           File "apache_beam/runners/worker/operations.py", line 226, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive
   E           File "apache_beam/runners/worker/operations.py", line 893, in apache_beam.runners.worker.operations.DoOperation.process
   E           File "apache_beam/runners/worker/operations.py", line 894, in apache_beam.runners.worker.operations.DoOperation.process
   E           File "apache_beam/runners/common.py", line 1406, in apache_beam.runners.common.DoFnRunner.process
   E           File "apache_beam/runners/common.py", line 1494, in apache_beam.runners.common.DoFnRunner._reraise_augmented
   E           File "apache_beam/runners/common.py", line 1404, in apache_beam.runners.common.DoFnRunner.process
   E           File "apache_beam/runners/common.py", line 624, in apache_beam.runners.common.SimpleInvoker.invoke_process
   E           File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python38/src/sdks/python/apache_beam/io/gcp/bigquery_json_it_test.py", line 103, in process
   E             self.assertEqual(country_expected, country_actual)
   E           File "/usr/local/lib/python3.8/unittest/case.py", line 911, in assertEqual
   E             assertion_func = self._getAssertEqualityFunc(first, second)
   E           File "/usr/local/lib/python3.8/unittest/case.py", line 892, in _getAssertEqualityFunc
   E             asserter = self._type_equality_funcs.get(type(first))
   E         AttributeError: 'CompareJson' object has no attribute '_type_equality_funcs' [while running 'Validate rows']
   
   apache_beam/runners/dataflow/dataflow_runner.py:1672: DataflowRuntimeException
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] codecov[bot] commented on pull request #17551: Better test assertion.

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17551:
URL: https://github.com/apache/beam/pull/17551#issuecomment-1118030366

   # [Codecov](https://codecov.io/gh/apache/beam/pull/17551?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17551](https://codecov.io/gh/apache/beam/pull/17551?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c3e973) into [master](https://codecov.io/gh/apache/beam/commit/77833b19371a213ef11439b2925fa421af79b641?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77833b1) will **increase** coverage by `0.02%`.
   > The diff coverage is `71.42%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #17551      +/-   ##
   ==========================================
   + Coverage   73.86%   73.88%   +0.02%     
   ==========================================
     Files         690      691       +1     
     Lines       91039    91373     +334     
   ==========================================
   + Hits        67242    67514     +272     
   - Misses      22577    22639      +62     
     Partials     1220     1220              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.69% <64.70%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/17551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...eam/runners/interactive/display/display\_manager.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L2Rpc3BsYXlfbWFuYWdlci5weQ==) | `0.00% <0.00%> (ø)` | |
   | [...beam/runners/interactive/display/pipeline\_graph.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3BpcGVsaW5lX2dyYXBoLnB5) | `80.15% <0.00%> (ø)` | |
   | [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `90.49% <0.00%> (ø)` | |
   | [sdks/go/pkg/beam/core/funcx/fn.go](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2Z1bmN4L2ZuLmdv) | `58.25% <100.00%> (ø)` | |
   | [...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=) | `86.36% <100.00%> (ø)` | |
   | [...ks/python/apache\_beam/runners/interactive/utils.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91dGlscy5weQ==) | `95.41% <100.00%> (ø)` | |
   | [sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==) | `94.49% <0.00%> (-2.51%)` | :arrow_down: |
   | [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
   | [sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=) | `87.94% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [18 more](https://codecov.io/gh/apache/beam/pull/17551/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17551?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17551?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a50718...4c3e973](https://codecov.io/gh/apache/beam/pull/17551?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] robertwb commented on pull request #17551: Better test assertion.

Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #17551:
URL: https://github.com/apache/beam/pull/17551#issuecomment-1118894287

   Unrelated failure in apache_beam.transforms.userstate_test.StatefulDoFnOnDirectRunnerTest.test_dynamic_timer_clear_then_set_timer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org