[GitHub] spark pull request: [SPARK-5644] [Core]Delete tmp dir when sc is s...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4412#discussion_r24245999
  
    --- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
    @@ -50,6 +50,15 @@ private[spark] class HttpFileServer(
     
       def stop() {
         httpServer.stop()
    +    
    +    // If we only stop sc, but the driver process still run as a services then we need to delete 
    +    // the tmp dir, if not, it will create too many tmp dirs
    +    try {
    +      Utils.deleteRecursively(baseDir)
    --- End diff --
    
    This seems OK to me. I would make the error log a warning though as it's non-fatal. Consider using an interpolated string here as you do below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org