You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 08:03:50 UTC

[GitHub] [spark] maropu commented on pull request #28733: [SPARK-31705][SQL] Push more possible predicates through Join via CNF conversion

maropu commented on pull request #28733:
URL: https://github.com/apache/spark/pull/28733#issuecomment-642483286


   (Just to check) Btw, it seems the previous works about CNF tried to implement this conversion in an independent rule for `Filter` plans  (e.g., the @viirya one: https://github.com/apache/spark/pull/15558/files#diff-a1acb054bc8888376603ef510e6d0ee0R139). On the other hand, this PR only targets at join queries. Is this because this conversion has a severe trade-off relationship between time complexity / performance gains, but join quries can get much performance improvements even in this case? Is my understanding correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org