You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/02 11:04:01 UTC
[GitHub] [airflow] Walderman opened a new pull request #16773: Fix dml buttons visibility on users view
Walderman opened a new pull request #16773:
URL: https://github.com/apache/airflow/pull/16773
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #16202
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
This PR fixes #16202 where Add/Edit/Delete buttons/permissions are missing when using OUATH, LDAP authentication providers even for admin role.
I was able to replicate the issue and tested that my changes resolve the problem (tested with Google OUATH and with LDAP).
This is my first PR, I went through all the docs, but please advise if I missed something.
@jhtimmins , could you please have a look?
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16773: Fix dml buttons visibility on users view
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16773:
URL: https://github.com/apache/airflow/pull/16773#discussion_r666072134
##########
File path: airflow/www/views.py
##########
@@ -4236,18 +4236,11 @@ class CustomViewMenuModelView(ViewMenuModelView):
]
-class CustomUserDBModelView(UserDBModelView):
- """Customize permission names for FAB's builtin UserDBModelView."""
+class CustomUserCommonModelView():
Review comment:
```suggestion
class CustomUserCommonModelView:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Walderman commented on a change in pull request #16773: Fix dml buttons visibility on users view
Posted by GitBox <gi...@apache.org>.
Walderman commented on a change in pull request #16773:
URL: https://github.com/apache/airflow/pull/16773#discussion_r670191027
##########
File path: airflow/www/views.py
##########
@@ -4236,18 +4236,11 @@ class CustomViewMenuModelView(ViewMenuModelView):
]
-class CustomUserDBModelView(UserDBModelView):
- """Customize permission names for FAB's builtin UserDBModelView."""
+class CustomUserCommonModelView():
+ """Customize permission names for FAB's builtin UserDBModelView. Common settings for all providers user views"""
Review comment:
thanks @ashb , i will update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Walderman commented on a change in pull request #16773: Fix dml buttons visibility on users view
Posted by GitBox <gi...@apache.org>.
Walderman commented on a change in pull request #16773:
URL: https://github.com/apache/airflow/pull/16773#discussion_r670208249
##########
File path: airflow/www/views.py
##########
@@ -4236,18 +4236,11 @@ class CustomViewMenuModelView(ViewMenuModelView):
]
-class CustomUserDBModelView(UserDBModelView):
- """Customize permission names for FAB's builtin UserDBModelView."""
+class CustomUserCommonModelView():
+ """Customize permission names for FAB's builtin UserDBModelView. Common settings for all providers user views"""
Review comment:
all users views for providers inherit from the common class that lists the crud permissions, so all of them will now have the add/delete/edit buttons available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16773: Fix dml buttons visibility on users view
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #16773:
URL: https://github.com/apache/airflow/pull/16773#issuecomment-872914051
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Walderman closed pull request #16773: Fix dml buttons visibility on users view
Posted by GitBox <gi...@apache.org>.
Walderman closed pull request #16773:
URL: https://github.com/apache/airflow/pull/16773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Walderman commented on pull request #16773: Fix dml buttons visibility on users view
Posted by GitBox <gi...@apache.org>.
Walderman commented on pull request #16773:
URL: https://github.com/apache/airflow/pull/16773#issuecomment-910161831
no longer required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16773: Fix dml buttons visibility on users view
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16773:
URL: https://github.com/apache/airflow/pull/16773#discussion_r666072236
##########
File path: airflow/www/views.py
##########
@@ -4236,18 +4236,11 @@ class CustomViewMenuModelView(ViewMenuModelView):
]
-class CustomUserDBModelView(UserDBModelView):
- """Customize permission names for FAB's builtin UserDBModelView."""
+class CustomUserCommonModelView():
+ """Customize permission names for FAB's builtin UserDBModelView. Common settings for all providers user views"""
Review comment:
Comment isn't right anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org