You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 15:27:56 UTC

[GitHub] [arrow-datafusion] Ted-Jiang commented on a change in pull request #2077: Fix lost filters and projections in ParquetExec, CSVExec etc

Ted-Jiang commented on a change in pull request #2077:
URL: https://github.com/apache/arrow-datafusion/pull/2077#discussion_r834438207



##########
File path: datafusion/tests/user_defined_plan.rs
##########
@@ -225,7 +225,9 @@ async fn topk_plan() -> Result<()> {
     let actual_output = exec_sql(&mut ctx, &explain_query).await?;
 
     // normalize newlines (output on windows uses \r\n)
-    let actual_output = actual_output.replace("\r\n", "\n");
+    let mut actual_output = actual_output.replace("\r\n", "\n");
+    actual_output.retain(|x| !x.is_ascii_whitespace());

Review comment:
       Everytime changing explain struct will add whitespace in output.
   Add this filter will make this test pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org