You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/10/04 19:08:12 UTC
[kudu-CR] cmake: rename integration-tests and mini-cluster
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8210
to review the following change.
Change subject: cmake: rename integration-tests and mini-cluster
......................................................................
cmake: rename integration-tests and mini-cluster
They are now called itest_util and mini_cluster, to be more consistent with
how we name our other cmake "library" modules.
Change-Id: I6afe9487279b65e342e529602127225536afb574
---
M src/kudu/benchmarks/CMakeLists.txt
M src/kudu/client/CMakeLists.txt
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
5 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/8210/1
--
To view, visit http://gerrit.cloudera.org:8080/8210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6afe9487279b65e342e529602127225536afb574
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] cmake: rename integration-tests and mini-cluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 )
Change subject: cmake: rename integration-tests and mini-cluster
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, known (very old) test flake.
--
To view, visit http://gerrit.cloudera.org:8080/8210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6afe9487279b65e342e529602127225536afb574
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 04 Oct 2017 20:32:39 +0000
Gerrit-HasComments: No
[kudu-CR] cmake: rename integration-tests and mini-cluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 )
Change subject: cmake: rename integration-tests and mini-cluster
......................................................................
Patch Set 2: Code-Review+2
Carrying forward Todd's +2.
--
To view, visit http://gerrit.cloudera.org:8080/8210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6afe9487279b65e342e529602127225536afb574
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 05 Oct 2017 04:43:28 +0000
Gerrit-HasComments: No
[kudu-CR] cmake: rename integration-tests and mini-cluster
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 )
Change subject: cmake: rename integration-tests and mini-cluster
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6afe9487279b65e342e529602127225536afb574
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 05 Oct 2017 03:14:33 +0000
Gerrit-HasComments: No
[kudu-CR] cmake: rename integration-tests and mini-cluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8210 )
Change subject: cmake: rename integration-tests and mini-cluster
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I6afe9487279b65e342e529602127225536afb574
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] cmake: rename integration-tests and mini-cluster
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8210 )
Change subject: cmake: rename integration-tests and mini-cluster
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6afe9487279b65e342e529602127225536afb574
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 04 Oct 2017 20:11:17 +0000
Gerrit-HasComments: No
[kudu-CR] cmake: rename integration-tests and mini-cluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8210 )
Change subject: cmake: rename integration-tests and mini-cluster
......................................................................
cmake: rename integration-tests and mini-cluster
They are now called itest_util and mini_cluster, to be more consistent with
how we name our other cmake "library" modules.
Change-Id: I6afe9487279b65e342e529602127225536afb574
Reviewed-on: http://gerrit.cloudera.org:8080/8210
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/benchmarks/CMakeLists.txt
M src/kudu/client/CMakeLists.txt
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
5 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6afe9487279b65e342e529602127225536afb574
Gerrit-Change-Number: 8210
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>