You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/09/11 15:05:15 UTC

[arrow] branch master updated: ARROW-3213: [C++] Use CMake to build vendored Snappy on Windows

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 758be7a  ARROW-3213: [C++] Use CMake to build vendored Snappy on Windows
758be7a is described below

commit 758be7acdaaa2460e91b4404b7381876eb8aa44c
Author: Kouhei Sutou <ko...@clear-code.com>
AuthorDate: Tue Sep 11 11:05:07 2018 -0400

    ARROW-3213: [C++] Use CMake to build vendored Snappy on Windows
    
    Because we can't run configure script on Windows.
    
    Author: Kouhei Sutou <ko...@clear-code.com>
    
    Closes #2538 from kou/cpp-use-cmake-to-build-vendored-snappy-with-mingw and squashes the following commits:
    
    811637d88 <Kouhei Sutou>  Use CMake to build vendored Snappy on Windows
---
 cpp/cmake_modules/ThirdpartyToolchain.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 36dcf30..ba36443 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -783,7 +783,7 @@ if (ARROW_WITH_SNAPPY)
       endif()
     endif()
 
-    if (MSVC)
+    if (WIN32)
       set(SNAPPY_CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
                             "-DCMAKE_CXX_FLAGS=${EP_CXX_FLAGS}"
                             "-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${EP_CXX_FLAGS}"