You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by nakomis <gi...@git.apache.org> on 2015/03/16 08:46:46 UTC

[GitHub] incubator-brooklyn pull request: Destroys machine on expunge, even...

GitHub user nakomis opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/553

    Destroys machine on expunge, even if stopped

    Fixes an issue where stopping an entity (with
    stopMachineMode of NEVER) and then attempting
    to expunge the top level application would
    unmanage the entity, but not destroy the VM

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nakomis/incubator-brooklyn fix/expunge-after-stop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #553
    
----
commit 25d4f5ff2b7e67a6837060ba9e5522e3f8849ad3
Author: Martin Harris <gi...@nakomis.com>
Date:   2015-03-16T07:44:18Z

    Destroys machine on expunge, even if stopped
    Fixes an issue where stopping an entity (with
    stopMachineMode of NEVER) and then attempting
    to expunge the top level application would
    unmanage the entity, but not destroy the VM

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Destroys machine on expunge, even...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/553#issuecomment-81737428
  
    Next time though, can you use a shorter first line for commit message. See discussion that we had previously on dev@brooklyn.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Destroys machine on expunge, even...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/553


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Destroys machine on expunge, even...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/553#issuecomment-81736022
  
    Looks good; merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---