You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/27 16:05:33 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #37999: [SPARK-39146][CORE][SQL] Introduce local singleton for `ObjectMapper` that may be reused

LuciferYang commented on code in PR #37999:
URL: https://github.com/apache/spark/pull/37999#discussion_r981438459


##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -1966,6 +1969,16 @@ private[spark] object Utils extends Logging {
     getHadoopFileSystem(new URI(path), conf)
   }
 
+  /**
+   * Return a new `ObjectMapper` with `ClassTagExtensions`.
+   * The mapper registers `DefaultScalaModule` by default.
+   */
+  def withScalaModuleMapper: ObjectMapper with ClassTagExtensions = {

Review Comment:
   Yes, it seems a little redundant and has been removed
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org