You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2012/10/25 23:09:14 UTC

[jira] [Created] (OAK-405) Property#getDefinition returns first residual definition instead of matching named definition

angela created OAK-405:
--------------------------

             Summary: Property#getDefinition returns first residual definition instead of matching named definition
                 Key: OAK-405
                 URL: https://issues.apache.org/jira/browse/OAK-405
             Project: Jackrabbit Oak
          Issue Type: Bug
          Components: jcr
            Reporter: angela


the current implementation of Property#getDefinition has the following
issue: while looping through the propertydefinitions defined by the
nodetypes of the parent it returns the wrong definition if there is
residual definition in the hierarchy that matches otherwise without
checking first if there was a matching named property definition.

IMO the code should first look for a name definition and only if there
is none look for a matching residual definition.

this can easily be tested by looking at the property definition of
rep:password defined by rep:User node type, which is with the current
code defined to be a residual property such as defined by the supertype.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (OAK-405) Node/Property getDefinition() returns first residual definition instead of matching named definition

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-405.
------------------------

    Resolution: Fixed
      Assignee: angela
    
> Node/Property getDefinition() returns first residual definition instead of matching named definition
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OAK-405
>                 URL: https://issues.apache.org/jira/browse/OAK-405
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: angela
>            Assignee: angela
>
> the current implementation of Property#getDefinition has the following
> issue: while looping through the propertydefinitions defined by the
> nodetypes of the parent it returns the wrong definition if there is
> residual definition in the hierarchy that matches otherwise without
> checking first if there was a matching named property definition.
> IMO the code should first look for a name definition and only if there
> is none look for a matching residual definition.
> this can easily be tested by looking at the property definition of
> rep:password defined by rep:User node type, which is with the current
> code defined to be a residual property such as defined by the supertype.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OAK-405) Property#getDefinition returns first residual definition instead of matching named definition

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484837#comment-13484837 ] 

angela commented on OAK-405:
----------------------------

the same applies for Node#getDefinition -> will adjust summary accordingly
                
> Property#getDefinition returns first residual definition instead of matching named definition
> ---------------------------------------------------------------------------------------------
>
>                 Key: OAK-405
>                 URL: https://issues.apache.org/jira/browse/OAK-405
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: angela
>
> the current implementation of Property#getDefinition has the following
> issue: while looping through the propertydefinitions defined by the
> nodetypes of the parent it returns the wrong definition if there is
> residual definition in the hierarchy that matches otherwise without
> checking first if there was a matching named property definition.
> IMO the code should first look for a name definition and only if there
> is none look for a matching residual definition.
> this can easily be tested by looking at the property definition of
> rep:password defined by rep:User node type, which is with the current
> code defined to be a residual property such as defined by the supertype.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OAK-405) Node/Property getDefinition() returns first residual definition instead of matching named definition

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated OAK-405:
-----------------------

    Summary: Node/Property getDefinition() returns first residual definition instead of matching named definition  (was: Property#getDefinition returns first residual definition instead of matching named definition)
    
> Node/Property getDefinition() returns first residual definition instead of matching named definition
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OAK-405
>                 URL: https://issues.apache.org/jira/browse/OAK-405
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: angela
>
> the current implementation of Property#getDefinition has the following
> issue: while looping through the propertydefinitions defined by the
> nodetypes of the parent it returns the wrong definition if there is
> residual definition in the hierarchy that matches otherwise without
> checking first if there was a matching named property definition.
> IMO the code should first look for a name definition and only if there
> is none look for a matching residual definition.
> this can easily be tested by looking at the property definition of
> rep:password defined by rep:User node type, which is with the current
> code defined to be a residual property such as defined by the supertype.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira