You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/08/26 19:03:55 UTC
(datafusion) branch main updated: docs: Remove stale "temporary fix" note from `get_record_batch_memory_size` (#24674)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 9617fdfee1 docs: Remove stale "temporary fix" note from `get_record_batch_memory_size` (#24674)
9617fdfee1 is described below
commit 9617fdfee12bd644d2c7ddebce99693780844f4e
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Wed Aug 26 18:48:48 2026 +0000
docs: Remove stale "temporary fix" note from `get_record_batch_memory_size` (#24674)
## Which issue does this PR close?
- N/A (minor doc fix).
- Follow on to #24637
## Rationale for this change
Address @nuno-faria 's comment addressing
https://github.com/apache/datafusion/pull/24637#discussion_r3856817631
This issue is complete, so we can remove the reference
- https://github.com/apache/arrow-rs/issues/6439
## What changes are included in this PR?
- Remove stale doc
## Are these changes tested?
CI
## Are there any user-facing changes?
Documentation only.
---
datafusion/common/src/utils/memory.rs | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/datafusion/common/src/utils/memory.rs b/datafusion/common/src/utils/memory.rs
index c68640d0fa..b842c7e21f 100644
--- a/datafusion/common/src/utils/memory.rs
+++ b/datafusion/common/src/utils/memory.rs
@@ -142,10 +142,9 @@ pub fn estimate_memory_size<T>(num_elements: usize, fixed_size: usize) -> Result
/// In the above case, `get_record_batch_memory_size` will return the size of
/// the buffer, instead of the sum of `col1` and `col2`'s actual memory size.
///
-/// Note: The current [`RecordBatch::get_array_memory_size`] will double count
-/// the buffer memory size if multiple arrays within the batch are sharing the
-/// same `Buffer`. This method provides a temporary fix until the issue is
-/// resolved: <https://github.com/apache/arrow-rs/issues/6439>
+/// Note: [`RecordBatch::get_array_memory_size`] double counts the buffer
+/// memory size if multiple arrays within the batch are sharing the same
+/// `Buffer`, while this function counts each `Buffer` exactly once.
pub fn get_record_batch_memory_size(batch: &RecordBatch) -> usize {
RecordBatchMemoryCounter::new().count_batch(batch)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org