You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Jorg Heymans <jh...@domek.be> on 2004/11/02 15:29:15 UTC
the multipartparser
Hi,
Is there a reason why we have our own multipart parser instead of using
commons-fileupload? This has come up already about 1.5 years ago [1].
I have a problem with the multipart parser in IE and Opera (not in
Firefox), reproduceable with the following form
<form name="myform" enctype="multipart/form-data" action="anypipeline"
method="POST">
<input type="submit"/>
</form>
results in
o.a.c.s.m.MultipartException: Malformed stream
at o.a.c.s.m.MultipartParser.parseMultiPart(MultipartParser.java:132)
at o.a.c.s.m.MultipartParser.getParts(MultipartParser.java:101)
at o.a.c.s.m.MultipartParser.getParts(MultipartParser.java:107)
at o.a.c.s.m.RequestFactory.getServletRequest(RequestFactory.java:94)
at o.a.c.s.CocoonServlet.service(CocoonServlet.java:1004)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
There is at least one other issue with it [2], and parsePart() in
MultiPartParser contains "// FIXME: multipart/mixed parts are untested."
Just wanted to get a few opinions before i attempt to implement this.
Regards
Jorg
[1] http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=105363507529701&w=2
[2] http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24289
Re: the multipartparser
Posted by Sylvain Wallez <sy...@apache.org>.
Micah Dubinko wrote:
> Hi Jorg,
>
> Very good. Let me ask a few questions.
>
> Which branch are you doing this on?
>
> Do you think it needs to be backported to the 2.1 branch?
Generally speaking, bug fixes and minor new features should go to the
both branches. More important changes should be first written for 2.2.
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Re: the multipartparser
Posted by Jorg Heymans <jh...@domek.be>.
Sorry Micah for the late reply, somehow completely missed updates on
this thread..
It's based on 2.1.x , bugzilla entry is [1] for the patch, discussion is
continuing at [2]
Jorg
[1] http://nagoya.apache.org/bugzilla/show_bug.cgi?id=32102
[2] http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=109990183914582&w=2
Micah Dubinko wrote:
> Hi Jorg,
>
> Very good. Let me ask a few questions.
>
> Which branch are you doing this on?
>
> Do you think it needs to be backported to the 2.1 branch?
>
> Can you send me the patches when there is something to look at?
>
> Thanks!
>
> .micah
>
> Jorg Heymans wrote:
>
>>
>>
>> Micah Dubinko wrote:
>>
>>> I want to get involved in Cocoon more, and wonder if this would be a
>>> good project to cut my teeth on.
>>
>>
>>
>> well i actually already started this - but that shouldn't stop you
>> from doing the same thing :)
>
>
>
Re: the multipartparser
Posted by Micah Dubinko <md...@snapbridge.com>.
Hi Jorg,
Very good. Let me ask a few questions.
Which branch are you doing this on?
Do you think it needs to be backported to the 2.1 branch?
Can you send me the patches when there is something to look at?
Thanks!
.micah
Jorg Heymans wrote:
>
>
> Micah Dubinko wrote:
>
>> I want to get involved in Cocoon more, and wonder if this would be a
>> good project to cut my teeth on.
>
>
> well i actually already started this - but that shouldn't stop you
> from doing the same thing :)
Re: the multipartparser
Posted by Jorg Heymans <jh...@domek.be>.
Micah Dubinko wrote:
> I want to get involved in Cocoon more, and wonder if this would be a
> good project to cut my teeth on.
>
> So, provided nobody objects, I'd like to volunteer to take on this
> little project. I'm sure I'll have some questions along the way, but
> nothing the fine folks on IRC or this list can't handle.
well i actually already started this - but that shouldn't stop you from
doing the same thing :)
Jorg
Re: the multipartparser
Posted by Micah Dubinko <md...@snapbridge.com>.
I want to get involved in Cocoon more, and wonder if this would be a
good project to cut my teeth on.
So, provided nobody objects, I'd like to volunteer to take on this
little project. I'm sure I'll have some questions along the way, but
nothing the fine folks on IRC or this list can't handle.
.micah
Ugo Cei wrote:
> Il giorno 02/nov/04, alle 15:29, Jorg Heymans ha scritto:
>
>> Is there a reason why we have our own multipart parser instead of
>> using commons-fileupload? This has come up already about 1.5 years
>> ago [1].
>
>
> Maybe when the multipart parser was invented, commons-fileupload
> wasn't yet there, or maybe it wasn't known or it was just a case of
> NIH syndrome. Anyway, if we can get the same functionality with
> commons-upload, let's drop this other reinvented wheel. +1 if you
> volunteer to do it.
>
> Ugo
>
Re: the multipartparser
Posted by Luigi Bai <lp...@focalpoint.com>.
I concer with Ugo. Please also see
http://issues.apache.org/bugzilla/show_bug.cgi?id=24289
for a patch to the current MultipartParser to handle multipar/mixed.
On Tue, 2 Nov 2004, Ugo Cei wrote:
> Il giorno 02/nov/04, alle 15:29, Jorg Heymans ha scritto:
>
>> Is there a reason why we have our own multipart parser instead of using
>> commons-fileupload? This has come up already about 1.5 years ago [1].
>
> Maybe when the multipart parser was invented, commons-fileupload wasn't yet
> there, or maybe it wasn't known or it was just a case of NIH syndrome.
> Anyway, if we can get the same functionality with commons-upload, let's drop
> this other reinvented wheel. +1 if you volunteer to do it.
>
> Ugo
>
> --
> Ugo Cei - http://beblogging.com/
>
Re: the multipartparser
Posted by Geoff Howard <ge...@gmail.com>.
On Tue, 2 Nov 2004 15:43:37 +0100, Ugo Cei <ug...@apache.org> wrote:
> Il giorno 02/nov/04, alle 15:29, Jorg Heymans ha scritto:
>
> > Is there a reason why we have our own multipart parser instead of
> > using commons-fileupload? This has come up already about 1.5 years ago
> > [1].
>
> Maybe when the multipart parser was invented, commons-fileupload wasn't
> yet there, or maybe it wasn't known or it was just a case of NIH
> syndrome. Anyway, if we can get the same functionality with
> commons-upload, let's drop this other reinvented wheel. +1 if you
> volunteer to do it.
Commons fileupload was spun off from Turbine in March of 2002. At the
time we relied on MaybeUpload. This was refactored here in late 2002
and again in early 2003
(http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=105366511921069&w=2)
and the dependency was removed.
Interestingly, the archive link above is Stefano responding to another
inquiry about commons upload.
This is a good discussion to have - see my responses in the other rfc thread.
Geoff
Re: the multipartparser
Posted by Ugo Cei <ug...@apache.org>.
Il giorno 02/nov/04, alle 15:29, Jorg Heymans ha scritto:
> Is there a reason why we have our own multipart parser instead of
> using commons-fileupload? This has come up already about 1.5 years ago
> [1].
Maybe when the multipart parser was invented, commons-fileupload wasn't
yet there, or maybe it wasn't known or it was just a case of NIH
syndrome. Anyway, if we can get the same functionality with
commons-upload, let's drop this other reinvented wheel. +1 if you
volunteer to do it.
Ugo
--
Ugo Cei - http://beblogging.com/