You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/11/06 06:05:14 UTC
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1307: ORC-1298:[C++] Support dedicated ColumnVectorBatch of numeric types
dongjoon-hyun commented on code in PR #1307:
URL: https://github.com/apache/orc/pull/1307#discussion_r1014774175
##########
c++/include/orc/Type.hh:
##########
@@ -70,10 +70,11 @@ namespace orc {
/**
* Create a row batch for this type.
*/
- virtual ORC_UNIQUE_PTR<ColumnVectorBatch> createRowBatch(uint64_t size,
- MemoryPool& pool,
- bool encoded = false
- ) const = 0;
+ virtual ORC_UNIQUE_PTR<ColumnVectorBatch> createRowBatch(
+ uint64_t size,
+ MemoryPool& pool,
+ bool encoded = false,
+ bool enableFixedWidthNumericVectorBatch = false) const = 0;
Review Comment:
@luffy-zh When you add one parameter, please avoid any change to the existing parameters. For example, indentation changes on line 73 to 76.
##########
c++/include/orc/Type.hh:
##########
@@ -70,10 +70,11 @@ namespace orc {
/**
* Create a row batch for this type.
*/
- virtual ORC_UNIQUE_PTR<ColumnVectorBatch> createRowBatch(uint64_t size,
- MemoryPool& pool,
- bool encoded = false
- ) const = 0;
+ virtual ORC_UNIQUE_PTR<ColumnVectorBatch> createRowBatch(
+ uint64_t size,
+ MemoryPool& pool,
+ bool encoded = false,
+ bool enableFixedWidthNumericVectorBatch = false) const = 0;
Review Comment:
@luffy-zh When you add one new parameter, please avoid any change to the existing parameters. For example, indentation changes on line 73 to 76.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org