You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "oleksandrshalbanov-dev (via GitHub)" <gi...@apache.org> on 2025/10/24 13:17:38 UTC
[I] Helm chart do not follow best practices for k8s manifests [superset]
oleksandrshalbanov-dev opened a new issue, #35830:
URL: https://github.com/apache/superset/issues/35830
## Description
Didn't find an appropriate category for this issue, so posting here.
Working with the Superset helm chart, I've figured out that manifests do not follow best practices described here:
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Currently, I can see the following labels:
labels:
app: superset
release: superset
app.kubernetes.io/managed-by: Helm
chart: superset-0.15.0
heritage: Helm
And here are selectors:
selector:
matchLabels:
app: superset
release: superset
I'd prefer to see here at leas the following labels and appropriate selector for deployments, services, etc:
labels:
app.kubernetes.io/instance: superset
app.kubernetes.io/name: superset
## Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label `design:review`. If this includes a design proposal,
include the label `design:suggest`]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Helm chart do not follow best practices for k8s manifests [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #35830:
URL: https://github.com/apache/superset/issues/35830#issuecomment-3457597374
Thanks for the PR! Helm is only semi-supported, so we'll do our best to get that through :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Helm chart do not follow best practices for k8s manifests [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #35830:
URL: https://github.com/apache/superset/issues/35830#issuecomment-4722013123
This has gone largely stale, but we ARE accepting last-mile touchups if you want to open a PR. Meanwhile, the Kubernetes Operator has shipped and is becoming the preferred approach. Closing this as stale/won't-fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Helm chart do not follow best practices for k8s manifests [superset]
Posted by "kwilt (via GitHub)" <gi...@apache.org>.
kwilt commented on issue #35830:
URL: https://github.com/apache/superset/issues/35830#issuecomment-3464218756
> Thanks for the PR! Helm is only semi-supported, so we'll do our best to get that through :D
Is there a fully-supported deployment method then? Official documentation and release notes state not to use Docker compose and that k8s is the 'best practice' way to deploy superset in production, and even encourages its use. There's hardly any documentation for PyPi deployments. Almost all documentation is centered around using Docker, even though k8s is considered best practice.
<img width="976" height="130" alt="Image" src="https://github.com/user-attachments/assets/d5c8221d-8afe-4123-b226-b2992b3f9304" />
<img width="978" height="157" alt="Image" src="https://github.com/user-attachments/assets/9fb7f2e8-264f-4c7c-afa4-2f8393ebd6e5" />
<img width="1012" height="68" alt="Image" src="https://github.com/user-attachments/assets/df65b46e-5644-48d1-91f6-d58566862117" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Helm chart do not follow best practices for k8s manifests [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #35830: Helm chart do not follow best practices for k8s manifests
URL: https://github.com/apache/superset/issues/35830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org