You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Shachar Shemesh <sh...@shemesh.biz> on 2008/12/15 10:49:38 UTC
Check in only for files not in changelist?
Hi,
I went over the docs, and I don't think I'm missing anything. In any
case, the default behavior for svn is confusing for me.
When one puts a file into a changelist, this may mean one of two things:
1. One wants to commit this file earlier than the rest of the modified files
2. One wants to put off committing this file
Option 1 is fairly well implemented, but option 2 does not appear to be
supported. I would expect, when typing "svn ci", that only those files
that do not belong to any change list be committed (with something along
the lines of "svn ci --cl all" for committing everything). This is not
the behavior on my system (version 1.5.1 from Debian Lenny). Instead,
everything is marked for commit when no explicit change list is given.
Alternatively, and with a lower preference on my part, the
"no-changelist" changelist should be named, so I can give a single
command to check in all those files that I have not explicitly placed in
a change list.
Thanks,
Shachar
P.s.
Please CC me, as I'm not subscribed to the list.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984353
Re: Check in only for files not in changelist?
Posted by Stefan Sperling <st...@elego.de>.
On Mon, Dec 15, 2008 at 12:49:38PM +0200, Shachar Shemesh wrote:
> Hi,
>
> I went over the docs, and I don't think I'm missing anything. In any
> case, the default behavior for svn is confusing for me.
> Please CC me, as I'm not subscribed to the list.
Hi,
please ask your question on users@subversion.tigris.org instead.
This list is for discussion of development of Subversion itself.
That is, if you have a patch that improves Subversion, please
post it here.
On this list, questions about using Subversion will most likely
be either ignored or redirected to users@ (the latter of which
I'm doing right now).
Thanks,
Stefan
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984493
Re: Check in only for files not in changelist?
Posted by "C. Michael Pilato" <cm...@collab.net>.
Greg Stein wrote:
> On Tue, Dec 16, 2008 at 14:18, Eric Gillespie <ep...@pretzelnet.org> wrote:
>> Ben Collins-Sussman <su...@red-bean.com> writes:
>>
>>> That said, your use-case #2 never occurred to me, nor have I ever
>>> heard anyone ask for it. I think it might be interesting to have a
>> It's pretty common. p4 has '-c default' and we implemented '-c
>> none' for gvn, which I found immensely useful. Maybe Shachar
>> would like to take a crack at it? :)
>
> There have been quite a few times that I've wanted to refer to "files
> not in a changelist" with svn. I have had a couple changes pending,
> marked as a changelist, but then do something *else* and want to
> "check that other stuff, not on a changelist". How to easily refer to
> those? If I do an "svn commit", will it do files *not* in a
> changelist, or does it grab all files? I'd also like to do "svn diff"
> on the not-changelist files.
Filed issue 3348 to track this:
http://subversion.tigris.org/issues/show_bug.cgi?id=3348
> It would lso be nice to say "add not-changelist files to <this> changelist".
>
> I've figured that --changelist "" would be nice to refer to the
> default, but it actually means a changelist named "".
If we had a way to specify non-changelist files using the --changelist param
(like, say, the empty changeset name), we'd get this for free:
$ svn cl --changelist "" new-changelist .
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=989803
Re: Check in only for files not in changelist?
Posted by Julian Foad <ju...@btopenworld.com>.
On Wed, 2008-12-17 at 09:46 -0500, C. Michael Pilato wrote:
> Greg Stein wrote:
> > On Tue, Dec 16, 2008 at 14:18, Eric Gillespie <ep...@pretzelnet.org> wrote:
> >> Ben Collins-Sussman <su...@red-bean.com> writes:
> >>
> >>> That said, your use-case #2 never occurred to me, nor have I ever
> >>> heard anyone ask for it. I think it might be interesting to have a
> >> It's pretty common. p4 has '-c default' and we implemented '-c
> >> none' for gvn, which I found immensely useful. Maybe Shachar
> >> would like to take a crack at it? :)
> >
> > There have been quite a few times that I've wanted to refer to "files
> > not in a changelist" with svn. I have had a couple changes pending,
> > marked as a changelist, but then do something *else* and want to
> > "check that other stuff, not on a changelist". How to easily refer to
> > those? If I do an "svn commit", will it do files *not* in a
> > changelist, or does it grab all files? I'd also like to do "svn diff"
> > on the not-changelist files.
> >
> > It would lso be nice to say "add not-changelist files to <this> changelist".
> >
> > I've figured that --changelist "" would be nice to refer to the
> > default, but it actually means a changelist named "".
>
> That's almost certainly not an intended consequence. I was going to, in
> fact, recommend that at the API level, we let the empty changelist name mean
> "not in a changelist", and at the UI level we add --without-changelist (as
> mutually exclusive with --changelist). I think we could make that change
> today without revving a bunch of APIs. Let's just call the current behavior
> a bug, because I can assure you that I didn't knowingly add that behavior
> when I rewrote this feature, and I betcha Ben didn't choose to allow that on
> purpose on his first crack at this, either.
+1 that it's a bug if the empty string can be used as a changelist name.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985750
Re: Check in only for files not in changelist?
Posted by Ben Collins-Sussman <su...@red-bean.com>.
Do it!
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985769
Re: Check in only for files not in changelist?
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
C. Michael Pilato wrote:
> Greg Stein wrote:
>> On Tue, Dec 16, 2008 at 14:18, Eric Gillespie <ep...@pretzelnet.org> wrote:
>>> Ben Collins-Sussman <su...@red-bean.com> writes:
>>>
>>>> That said, your use-case #2 never occurred to me, nor have I ever
>>>> heard anyone ask for it. I think it might be interesting to have a
>>> It's pretty common. p4 has '-c default' and we implemented '-c
>>> none' for gvn, which I found immensely useful. Maybe Shachar
>>> would like to take a crack at it? :)
>> There have been quite a few times that I've wanted to refer to "files
>> not in a changelist" with svn. I have had a couple changes pending,
>> marked as a changelist, but then do something *else* and want to
>> "check that other stuff, not on a changelist". How to easily refer to
>> those? If I do an "svn commit", will it do files *not* in a
>> changelist, or does it grab all files? I'd also like to do "svn diff"
>> on the not-changelist files.
>>
>> It would lso be nice to say "add not-changelist files to <this> changelist".
>>
>> I've figured that --changelist "" would be nice to refer to the
>> default, but it actually means a changelist named "".
>
> That's almost certainly not an intended consequence. I was going to, in
> fact, recommend that at the API level, we let the empty changelist name mean
> "not in a changelist", and at the UI level we add --without-changelist (as
> mutually exclusive with --changelist). I think we could make that change
> today without revving a bunch of APIs. Let's just call the current behavior
> a bug, because I can assure you that I didn't knowingly add that behavior
> when I rewrote this feature, and I betcha Ben didn't choose to allow that on
> purpose on his first crack at this, either.
Agreed. And even if the --without-changelist stuff doesn't get implemented in
time for 1.6, it'd probably be useful to put a simple check in the client
libraries to prevent unintended use of the empty changelist going forward.
-Hyrum
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985760
Re: Check in only for files not in changelist?
Posted by "C. Michael Pilato" <cm...@collab.net>.
Greg Stein wrote:
> On Tue, Dec 16, 2008 at 14:18, Eric Gillespie <ep...@pretzelnet.org> wrote:
>> Ben Collins-Sussman <su...@red-bean.com> writes:
>>
>>> That said, your use-case #2 never occurred to me, nor have I ever
>>> heard anyone ask for it. I think it might be interesting to have a
>> It's pretty common. p4 has '-c default' and we implemented '-c
>> none' for gvn, which I found immensely useful. Maybe Shachar
>> would like to take a crack at it? :)
>
> There have been quite a few times that I've wanted to refer to "files
> not in a changelist" with svn. I have had a couple changes pending,
> marked as a changelist, but then do something *else* and want to
> "check that other stuff, not on a changelist". How to easily refer to
> those? If I do an "svn commit", will it do files *not* in a
> changelist, or does it grab all files? I'd also like to do "svn diff"
> on the not-changelist files.
>
> It would lso be nice to say "add not-changelist files to <this> changelist".
>
> I've figured that --changelist "" would be nice to refer to the
> default, but it actually means a changelist named "".
That's almost certainly not an intended consequence. I was going to, in
fact, recommend that at the API level, we let the empty changelist name mean
"not in a changelist", and at the UI level we add --without-changelist (as
mutually exclusive with --changelist). I think we could make that change
today without revving a bunch of APIs. Let's just call the current behavior
a bug, because I can assure you that I didn't knowingly add that behavior
when I rewrote this feature, and I betcha Ben didn't choose to allow that on
purpose on his first crack at this, either.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985744
Re: Check in only for files not in changelist?
Posted by Greg Stein <gs...@gmail.com>.
On Tue, Dec 16, 2008 at 14:18, Eric Gillespie <ep...@pretzelnet.org> wrote:
> Ben Collins-Sussman <su...@red-bean.com> writes:
>
>> That said, your use-case #2 never occurred to me, nor have I ever
>> heard anyone ask for it. I think it might be interesting to have a
>
> It's pretty common. p4 has '-c default' and we implemented '-c
> none' for gvn, which I found immensely useful. Maybe Shachar
> would like to take a crack at it? :)
There have been quite a few times that I've wanted to refer to "files
not in a changelist" with svn. I have had a couple changes pending,
marked as a changelist, but then do something *else* and want to
"check that other stuff, not on a changelist". How to easily refer to
those? If I do an "svn commit", will it do files *not* in a
changelist, or does it grab all files? I'd also like to do "svn diff"
on the not-changelist files.
It would lso be nice to say "add not-changelist files to <this> changelist".
I've figured that --changelist "" would be nice to refer to the
default, but it actually means a changelist named "".
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985612
Re: Check in only for files not in changelist?
Posted by Eric Gillespie <ep...@pretzelnet.org>.
Ben Collins-Sussman <su...@red-bean.com> writes:
> That said, your use-case #2 never occurred to me, nor have I ever
> heard anyone ask for it. I think it might be interesting to have a
It's pretty common. p4 has '-c default' and we implemented '-c
none' for gvn, which I found immensely useful. Maybe Shachar
would like to take a crack at it? :)
--
Eric Gillespie <*> epg@pretzelnet.org
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985269
Re: Check in only for files not in changelist?
Posted by Ben Collins-Sussman <su...@red-bean.com>.
On Mon, Dec 15, 2008 at 4:49 AM, Shachar Shemesh <sh...@shemesh.biz> wrote:
> Hi,
>
> I went over the docs, and I don't think I'm missing anything. In any
> case, the default behavior for svn is confusing for me.
>
> When one puts a file into a changelist, this may mean one of two things:
> 1. One wants to commit this file earlier than the rest of the modified files
> 2. One wants to put off committing this file
>
> Option 1 is fairly well implemented, but option 2 does not appear to be
> supported. I would expect, when typing "svn ci", that only those files
> that do not belong to any change list be committed (with something along
> the lines of "svn ci --cl all" for committing everything). This is not
> the behavior on my system (version 1.5.1 from Debian Lenny). Instead,
> everything is marked for commit when no explicit change list is given.
Changelists are simply a facility for labeling groups of modified
files. These labels are completely ignored *unless* you specify
--changelist to subcommands. If there's no --changelist flag, then
the commands behave the same way they've always behaved, before the
changelist feature existed.
That said, your use-case #2 never occurred to me, nor have I ever
heard anyone ask for it. I think it might be interesting to have a
way of saying "all changed files NOT in this changelist", or "all
changed files which are not part of any changelist." It would be a
fair amount of work to implement such a thing though. You'd have to
write a designdoc and such. :-)
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984506