Re: [PR] Handle non-finite bounds in BigIntegerValidator range checks [commons-validator]

["sahvx655-wq (via GitHub)" <gi...@apache.org>]

sahvx655-wq commented on PR #414:
URL: https://github.com/apache/commons-validator/pull/414#issuecomment-4877089440

   Good point. I've extended testNumberRangeNonFiniteBound to exercise non-finite operands on both sides: each infinity against itself, the two infinities against each other, and NaN against NaN. Since the non-finite path falls back to the doubleValue() comparison, an infinity equals itself and orders correctly against the other infinity, while anything involving NaN comes back false, which is what those new assertions pin down.
   
   On #410, that's since been merged, so it should be sorted now. I'll keep a closer eye on the state of the open ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org