You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/22 07:17:18 UTC
[GitHub] [pulsar] wangjialing218 opened a new pull request #11427: add error log for schema admin operation
wangjialing218 opened a new pull request #11427:
URL: https://github.com/apache/pulsar/pull/11427
### Motivation
When I use pulsar-admin schemas to upload schema file with wrong format, I got `HTTP 500 Internal Server Error` from pulsar-admin-tool.
And I look into broker's log but can not find any related error logs.
### Modifications
export error log when schema admin operation failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #11427: add error log for schema admin operation
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #11427:
URL: https://github.com/apache/pulsar/pull/11427#issuecomment-884792935
I think this PR do not need to update docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #11427: add error log for schema admin operation
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11427:
URL: https://github.com/apache/pulsar/pull/11427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #11427: add error log for schema admin operation
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #11427:
URL: https://github.com/apache/pulsar/pull/11427#issuecomment-885383407
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11427: add error log for schema admin operation
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11427:
URL: https://github.com/apache/pulsar/pull/11427#issuecomment-884786664
@wangjialing218 Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on a change in pull request #11427: add error log for schema admin operation
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on a change in pull request #11427:
URL: https://github.com/apache/pulsar/pull/11427#discussion_r675419118
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java
##########
@@ -294,4 +302,6 @@ private void validateDestinationAndAdminOperation(boolean authoritative) {
}
}
}
+
+ private static final Logger log = LoggerFactory.getLogger(SchemasResourceBase.class);
Review comment:
Thanks. I just copied this usage from other Class like 'TenantsBase' in same package, we could change to `@Slf4j` for all those Class in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #11427: add error log for schema admin operation
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #11427:
URL: https://github.com/apache/pulsar/pull/11427#discussion_r675379208
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java
##########
@@ -294,4 +302,6 @@ private void validateDestinationAndAdminOperation(boolean authoritative) {
}
}
}
+
+ private static final Logger log = LoggerFactory.getLogger(SchemasResourceBase.class);
Review comment:
nit:
please use `@Slf4j` annotation from lombok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org