You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/10/25 19:26:28 UTC
[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17965
Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
......................................................................
[mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
This is a follow-up to 2ca437e25e93dba3d3678dd20d92ffa0b4ba2e29.
Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
---
M src/kudu/tablet/mvcc.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/17965/1
--
To view, visit http://gerrit.cloudera.org:8080/17965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17965 )
Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:31:56 +0000
Gerrit-HasComments: No
[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17965 )
Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
......................................................................
Patch Set 1:
unrelated test failures in
* AuthzProvidersWithOwner/MasterAuthzOwnerITest.TestMismatchedTable/Ranger_nonowner
* HmsConfigurations/MasterFailoverTest.TestMasterPermanentFailure/0
--
To view, visit http://gerrit.cloudera.org:8080/17965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:04:29 +0000
Gerrit-HasComments: No
[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17965 )
Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:04:35 +0000
Gerrit-HasComments: No
[kudu-CR] [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17965 )
Change subject: [mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
......................................................................
[mvcc] avoid copying in AnyApplyingAtOrBeforeUnlocked()
This is a follow-up to 2ca437e25e93dba3d3678dd20d92ffa0b4ba2e29.
Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
Reviewed-on: http://gerrit.cloudera.org:8080/17965
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tablet/mvcc.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c1522028e0a1a5c1696e459861133adf30eb598
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)