You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/27 11:19:12 UTC

[GitHub] [dubbo-go-pixiu] mark4z opened a new pull request #307: [WIP] filter split

mark4z opened a new pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (905c4da) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `0.80%`.
   > The diff coverage is `44.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   37.32%   +0.80%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3113     -140     
   ===========================================
   - Hits          1188     1162      -26     
   + Misses        1945     1834     -111     
   + Partials       120      117       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `8.57% <0.00%> (+1.90%)` | :arrow_up: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <0.00%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <0.00%> (ø)` | |
   | [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `30.30% <33.33%> (-48.49%)` | :arrow_down: |
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `47.72% <33.33%> (-11.37%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...905c4da](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9322277) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/04933a95f3cff1fd4788d1f5cb543347a5cb75a5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04933a9) will **increase** coverage by `2.11%`.
   > The diff coverage is `45.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.78%   38.89%   +2.11%     
   ===========================================
     Files           54       53       -1     
     Lines         3262     3121     -141     
   ===========================================
   + Hits          1200     1214      +14     
   + Misses        1938     1778     -160     
   - Partials       124      129       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `46.29% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `41.17% <20.00%> (-2.58%)` | :arrow_down: |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `25.80% <23.07%> (-40.87%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `54.41% <44.44%> (+48.25%)` | :arrow_up: |
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `54.09% <44.73%> (-12.57%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04933a9...9322277](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur commented on a change in pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
ztelur commented on a change in pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#discussion_r771887821



##########
File path: pkg/filter/tracing/tracing.go
##########
@@ -92,8 +96,10 @@ func (m *TraceFilter) Apply() error {
 	return nil
 }
 
-func (mf *TraceFilter) PrepareFilterChain(ctx *contexthttp.HttpContext) error {
-	ctx.AppendFilterFunc(mf.Handle)
+func (mf *TraceFilterFilter) PrepareFilterChain(ctx *contexthttp.HttpContext, chain filter.FilterChain) error {

Review comment:
       应该是 factory 和 filter 混淆了

##########
File path: pkg/common/http/manager.go
##########
@@ -58,35 +62,75 @@ func (hcm *HttpConnectionManager) OnData(hc *pch.HttpContext) error {
 	if err != nil {
 		return err
 	}
-	hcm.addFilter(hc)
 	hcm.handleHTTPRequest(hc)
 	return nil
 }
 
 // handleHTTPRequest handle http request
 func (hcm *HttpConnectionManager) handleHTTPRequest(c *pch.HttpContext) {
-	if len(c.Filters) > 0 {
-		c.Next()
-		return
+	filterChain := hcm.filterManager.CreateFilterChain(c)
+
+	// recover any err when filterChain run
+	defer func() {
+		if err := recover(); err != nil {
+			logger.Warnf("[dubbopixiu go] Occur An Unexpected Err: %+v", err)
+			c.SendLocalReply(http.StatusInternalServerError, []byte(fmt.Sprintf("Occur An Unexpected Err: %v", err)))
+		}
+	}()
+
+	//todo timeout
+	filterChain.OnDecode(c)
+	hcm.buildTargetResponse(c)
+	filterChain.OnEncode(c)
+	hcm.writeResponse(c)
+}
+
+func (hcm *HttpConnectionManager) writeResponse(c *pch.HttpContext) {
+	if !c.LocalReply() {
+		writer := c.Writer
+		writer.WriteHeader(c.GetStatusCode())
+		if _, err := writer.Write(c.TargetResp.Data); err != nil {
+			panic(err)
+		}
 	}
-	// TODO redirect
 }
 
-func (hcm *HttpConnectionManager) addFilter(ctx *pch.HttpContext) {
-	for _, f := range hcm.filterManager.GetFilters() {
-		if err := (*f).PrepareFilterChain(ctx); err != nil {
-			logger.Warnf("PrepareFilterChain error %s", err)
+func (hcm *HttpConnectionManager) buildTargetResponse(c *pch.HttpContext) {
+	if !c.LocalReply() {

Review comment:
       可以及早return，不过 isLocalReply 的情况是否需要打印日志

##########
File path: samples/dubbogo/multi/config/conf.yaml
##########
@@ -57,8 +57,7 @@ static_resources:
                         timeout_config:
                           connect_timeout: 5s
                           request_timeout: 5s
-                  - name: dgp.filter.http.response

Review comment:
       👍

##########
File path: pkg/common/extension/filter/filter_manager.go
##########
@@ -27,32 +27,42 @@ import (
 
 import (
 	"github.com/apache/dubbo-go-pixiu/pkg/common/yaml"
+	"github.com/apache/dubbo-go-pixiu/pkg/context/http"
 	"github.com/apache/dubbo-go-pixiu/pkg/logger"
 	"github.com/apache/dubbo-go-pixiu/pkg/model"
 )
 
 // FilterManager manage filters
 type FilterManager struct {
-	filters       map[string]HttpFilter
-	filtersArray  []*HttpFilter
+	filters       map[string]HttpFilterFactory
+	filtersArray  []*HttpFilterFactory
 	filterConfigs []*model.HTTPFilter
 
 	mu sync.RWMutex
 }
 
 // NewFilterManager create filter manager
 func NewFilterManager(fs []*model.HTTPFilter) *FilterManager {
-	fm := &FilterManager{filterConfigs: fs, filters: make(map[string]HttpFilter)}
+	fm := &FilterManager{filterConfigs: fs, filters: make(map[string]HttpFilterFactory)}
 	return fm
 }
 
 // NewEmptyFilterManager create empty filter manager
 func NewEmptyFilterManager() *FilterManager {
-	return &FilterManager{filters: make(map[string]HttpFilter)}
+	return &FilterManager{filters: make(map[string]HttpFilterFactory)}
 }
 
-// GetFilters get all filter from manager
-func (fm *FilterManager) GetFilters() []*HttpFilter {
+func (fm *FilterManager) CreateFilterChain(ctx *http.HttpContext) FilterChain {
+	chain := NewDefaultFilterChain()
+
+	for _, f := range fm.GetFactory() {
+		_ = (*f).PrepareFilterChain(ctx, chain)
+	}
+	return chain
+}
+
+// GetFactory get all filter from manager
+func (fm *FilterManager) GetFactory() []*HttpFilterFactory {
 	fm.mu.RLock()

Review comment:
       是否其他使用 filtersArray 处也要加锁？

##########
File path: pkg/filter/tracing/tracing.go
##########
@@ -68,15 +72,15 @@ func (ap *Plugin) Kind() string {
 	return constant.TracingFilter
 }
 
-func (ap *Plugin) CreateFilter() (filter.HttpFilter, error) {
-	return &TraceFilter{cfg: &TraceConfig{}}, nil
+func (ap *Plugin) CreateFilterFactory() (filter.HttpFilterFactory, error) {
+	return &TraceFilterFilter{cfg: &TraceConfig{}}, nil

Review comment:
       是不是命名有些问题？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] PhilYue commented on a change in pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
PhilYue commented on a change in pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#discussion_r777204196



##########
File path: pkg/common/extension/filter/filter_chain.go
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package filter
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/context/http"
+)
+
+//FilterChain
+type FilterChain interface {
+	AppendDecodeFilters(f ...HttpDecodeFilter)
+	AppendEncodeFilters(f ...HttpEncodeFilter)
+
+	OnDecode(ctx *http.HttpContext)
+	OnEncode(ctx *http.HttpContext)
+}
+
+type defaultFilterChain struct {
+	decodeFilters      []HttpDecodeFilter
+	decodeFiltersIndex int
+
+	encodeFilters      []HttpEncodeFilter
+	encodeFiltersIndex int
+}
+
+func NewDefaultFilterChain() FilterChain {
+	return &defaultFilterChain{
+		decodeFilters:      []HttpDecodeFilter{},
+		decodeFiltersIndex: 0,
+		encodeFilters:      []HttpEncodeFilter{},
+		encodeFiltersIndex: 0,
+	}
+}
+
+func (c *defaultFilterChain) AppendDecodeFilters(f ...HttpDecodeFilter) {
+	c.decodeFilters = append(c.decodeFilters, f...)
+}
+
+// AppendEncodeFilters append encode filters in reverse order
+func (c *defaultFilterChain) AppendEncodeFilters(f ...HttpEncodeFilter) {
+	for i := len(f) - 1; i >= 0; i-- {
+		c.encodeFilters = append([]HttpEncodeFilter{f[i]}, c.encodeFilters...)
+	}
+}
+
+func (c *defaultFilterChain) OnDecode(ctx *http.HttpContext) {
+	for ; c.decodeFiltersIndex < len(c.decodeFilters); c.decodeFiltersIndex++ {
+		filterStatus := c.decodeFilters[c.decodeFiltersIndex].Decode(ctx)
+
+		switch filterStatus {
+		case Continue:
+			continue
+		case Stop:
+			return

Review comment:
       状态变更这里是否要加日志，方便排查定位




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4bb4b0) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `1.63%`.
   > The diff coverage is `44.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   38.15%   +1.63%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3116     -137     
   ===========================================
   + Hits          1188     1189       +1     
   + Misses        1945     1807     -138     
     Partials       120      120              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <0.00%> (ø)` | |
   | [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `30.30% <33.33%> (-48.49%)` | :arrow_down: |
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `47.72% <33.33%> (-11.37%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `54.41% <41.17%> (+48.25%)` | :arrow_up: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | ... and [13 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...d4bb4b0](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3291aa9) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `2.11%`.
   > The diff coverage is `45.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   38.63%   +2.11%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3114     -139     
   ===========================================
   + Hits          1188     1203      +15     
   + Misses        1945     1787     -158     
   - Partials       120      124       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `41.17% <20.00%> (-2.58%)` | :arrow_down: |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `25.80% <23.07%> (-40.87%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `54.41% <41.17%> (+48.25%)` | :arrow_up: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `56.66% <48.64%> (-10.00%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...3291aa9](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (707a632) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/04933a95f3cff1fd4788d1f5cb543347a5cb75a5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04933a9) will **increase** coverage by `2.11%`.
   > The diff coverage is `45.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.78%   38.89%   +2.11%     
   ===========================================
     Files           54       53       -1     
     Lines         3262     3121     -141     
   ===========================================
   + Hits          1200     1214      +14     
   + Misses        1938     1778     -160     
   - Partials       124      129       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `46.29% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `41.17% <20.00%> (-2.58%)` | :arrow_down: |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `25.80% <23.07%> (-40.87%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `54.41% <44.44%> (+48.25%)` | :arrow_up: |
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `54.09% <44.73%> (-12.57%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04933a9...707a632](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] PhilYue commented on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
PhilYue commented on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-1003712584


   Case：如果我自定义的 Filter 没有成对的 Append `Encode` 和 `Decode`，比如只 `chain.AppendDecodeFilters(f)`，对 Filter 整体执行结果有什么影响？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (905c4da) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `0.80%`.
   > The diff coverage is `44.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   37.32%   +0.80%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3113     -140     
   ===========================================
   - Hits          1188     1162      -26     
   + Misses        1945     1834     -111     
   + Partials       120      117       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `8.57% <0.00%> (+1.90%)` | :arrow_up: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <0.00%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <0.00%> (ø)` | |
   | [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `30.30% <33.33%> (-48.49%)` | :arrow_down: |
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `47.72% <33.33%> (-11.37%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...905c4da](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on a change in pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
mark4z commented on a change in pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#discussion_r772370046



##########
File path: pkg/filter/tracing/tracing.go
##########
@@ -68,15 +72,15 @@ func (ap *Plugin) Kind() string {
 	return constant.TracingFilter
 }
 
-func (ap *Plugin) CreateFilter() (filter.HttpFilter, error) {
-	return &TraceFilter{cfg: &TraceConfig{}}, nil
+func (ap *Plugin) CreateFilterFactory() (filter.HttpFilterFactory, error) {
+	return &TraceFilterFilter{cfg: &TraceConfig{}}, nil

Review comment:
       确实




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z closed pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
mark4z closed pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z closed pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
mark4z closed pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991671184


   #253 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991671184


   #253 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (564341c) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `2.08%`.
   > The diff coverage is `44.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   38.60%   +2.08%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3116     -137     
   ===========================================
   + Hits          1188     1203      +15     
   + Misses        1945     1789     -156     
   - Partials       120      124       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `41.17% <20.00%> (-2.58%)` | :arrow_down: |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `25.80% <23.07%> (-40.87%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `54.41% <44.44%> (+48.25%)` | :arrow_up: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `56.66% <48.64%> (-10.00%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...564341c](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (905c4da) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `0.80%`.
   > The diff coverage is `44.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   37.32%   +0.80%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3113     -140     
   ===========================================
   - Hits          1188     1162      -26     
   + Misses        1945     1834     -111     
   + Partials       120      117       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `8.57% <0.00%> (+1.90%)` | :arrow_up: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <0.00%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <0.00%> (ø)` | |
   | [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `30.30% <33.33%> (-48.49%)` | :arrow_down: |
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `47.72% <33.33%> (-11.37%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...905c4da](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0c0eef) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `0.80%`.
   > The diff coverage is `44.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   37.32%   +0.80%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3113     -140     
   ===========================================
   - Hits          1188     1162      -26     
   + Misses        1945     1834     -111     
   + Partials       120      117       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `8.57% <0.00%> (+1.90%)` | :arrow_up: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <0.00%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <0.00%> (ø)` | |
   | [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `30.30% <33.33%> (-48.49%)` | :arrow_down: |
   | [pkg/filter/ratelimit/rate\_limit.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yYXRlbGltaXQvcmF0ZV9saW1pdC5nbw==) | `47.72% <33.33%> (-11.37%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...d0c0eef](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6a97af) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `2.08%`.
   > The diff coverage is `44.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   38.60%   +2.08%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3116     -137     
   ===========================================
   + Hits          1188     1203      +15     
   + Misses        1945     1789     -156     
   - Partials       120      124       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `41.17% <20.00%> (-2.58%)` | :arrow_down: |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `25.80% <23.07%> (-40.87%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `54.41% <44.44%> (+48.25%)` | :arrow_up: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `56.66% <48.64%> (-10.00%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...e6a97af](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur commented on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
ztelur commented on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-997319062


   Thanks for preparing the PR! rest LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on a change in pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
mark4z commented on a change in pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#discussion_r772368219



##########
File path: pkg/common/http/manager.go
##########
@@ -58,35 +62,75 @@ func (hcm *HttpConnectionManager) OnData(hc *pch.HttpContext) error {
 	if err != nil {
 		return err
 	}
-	hcm.addFilter(hc)
 	hcm.handleHTTPRequest(hc)
 	return nil
 }
 
 // handleHTTPRequest handle http request
 func (hcm *HttpConnectionManager) handleHTTPRequest(c *pch.HttpContext) {
-	if len(c.Filters) > 0 {
-		c.Next()
-		return
+	filterChain := hcm.filterManager.CreateFilterChain(c)
+
+	// recover any err when filterChain run
+	defer func() {
+		if err := recover(); err != nil {
+			logger.Warnf("[dubbopixiu go] Occur An Unexpected Err: %+v", err)
+			c.SendLocalReply(http.StatusInternalServerError, []byte(fmt.Sprintf("Occur An Unexpected Err: %v", err)))
+		}
+	}()
+
+	//todo timeout
+	filterChain.OnDecode(c)
+	hcm.buildTargetResponse(c)
+	filterChain.OnEncode(c)
+	hcm.writeResponse(c)
+}
+
+func (hcm *HttpConnectionManager) writeResponse(c *pch.HttpContext) {
+	if !c.LocalReply() {
+		writer := c.Writer
+		writer.WriteHeader(c.GetStatusCode())
+		if _, err := writer.Write(c.TargetResp.Data); err != nil {
+			panic(err)
+		}
 	}
-	// TODO redirect
 }
 
-func (hcm *HttpConnectionManager) addFilter(ctx *pch.HttpContext) {
-	for _, f := range hcm.filterManager.GetFilters() {
-		if err := (*f).PrepareFilterChain(ctx); err != nil {
-			logger.Warnf("PrepareFilterChain error %s", err)
+func (hcm *HttpConnectionManager) buildTargetResponse(c *pch.HttpContext) {
+	if !c.LocalReply() {

Review comment:
       return提前短路没问题，至于filter中断的日志，由filter打印比较好。毕竟acl filter也会打印




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] AlexStocks commented on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991859874


   @mark4z plx fix the github action bugs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #307: filter work flow rafactor

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #307:
URL: https://github.com/apache/dubbo-go-pixiu/pull/307#issuecomment-991836578


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#307](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6de2cf) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/3f9c2536ae42c535164d735f746b70a2f698031e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f9c253) will **increase** coverage by `2.08%`.
   > The diff coverage is `44.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #307      +/-   ##
   ===========================================
   + Coverage    36.52%   38.60%   +2.08%     
   ===========================================
     Files           54       53       -1     
     Lines         3253     3116     -137     
   ===========================================
   + Hits          1188     1203      +15     
   + Misses        1945     1789     -156     
   - Partials       120      124       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlci5nbw==) | `29.16% <ø> (ø)` | |
   | [pkg/common/util/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlsL3Jlc3BvbnNlLmdv) | `44.24% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `0.00% <0.00%> (-6.67%)` | :arrow_down: |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `41.17% <20.00%> (-2.58%)` | :arrow_down: |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `25.80% <23.07%> (-40.87%)` | :arrow_down: |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `34.21% <43.75%> (-30.50%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `54.41% <44.44%> (+48.25%)` | :arrow_up: |
   | [pkg/filter/http/proxyrewrite/rewrite.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9odHRwL3Byb3h5cmV3cml0ZS9yZXdyaXRlLmdv) | `53.33% <47.61%> (ø)` | |
   | [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `56.66% <48.64%> (-10.00%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f9c253...f6de2cf](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/307?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org