You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jgenender <gi...@git.apache.org> on 2015/04/14 18:08:27 UTC
[GitHub] activemq-6 pull request: ACTIVEMQ6-97 - Change HQ to AMQ for prope...
GitHub user jgenender opened a pull request:
https://github.com/apache/activemq-6/pull/205
ACTIVEMQ6-97 - Change HQ to AMQ for properties/headers/doc. Remove as mu...
...ch HQ as possible and change to AMQ to make this close to the ActiveMQ project.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jgenender/activemq-6 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit 19b7b06346a3f85b351f5f314d4acd5f2bda4ad1
Author: Jeff Genender <jg...@savoirtech.com>
Date: 2015-04-14T16:07:26Z
ACTIVEMQ6-97 - Change HQ to AMQ for properties/headers/doc. Remove as much HQ as possible and change to AMQ to make this close to the ActiveMQ project.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-97 - Change HQ to AMQ for prope...
Posted by jgenender <gi...@git.apache.org>.
Github user jgenender commented on the pull request:
https://github.com/apache/activemq-6/pull/205#issuecomment-92984868
Absolutely.
Thanks,
Jeff
> On Apr 14, 2015, at 11:11 AM, clebertsuconic <no...@github.com> wrote:
>
> We will need to fix the testsuite before being able to merge this one...
>
> @jgenender <https://github.com/jgenender> you used your master for this... this PR will probably be open for a few days...
>
> Can you make sure you open a new branch if you send another PR non related to this?
>
> I will need a few days before I can merge this mainly because of the testsuite.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/apache/activemq-6/pull/205#issuecomment-92983909>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-97 - Change HQ to AMQ for prope...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-6/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-97 - Change HQ to AMQ for prope...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/205#issuecomment-92983909
We will need to fix the testsuite before being able to merge this one...
@jgenender you used your master for this... this PR will probably be open for a few days...
Can you make sure you open a new branch if you send another PR non related to this?
I will need a few days before I can merge this mainly because of the testsuite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-97 - Change HQ to AMQ for prope...
Posted by HornetQBot <gi...@git.apache.org>.
Github user HornetQBot commented on the pull request:
https://github.com/apache/activemq-6/pull/205#issuecomment-92938168
Can one of the admins verify this patch by saying "ok to test"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-97 - Change HQ to AMQ for prope...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-6/pull/205#issuecomment-92982918
We will merge this.. I just want to have a thought about client compatibility and look through this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-97 - Change HQ to AMQ for prope...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-6/pull/205#issuecomment-92938159
My understanding is that these properties weren't change due to compatibility with older HornetQ clients. Have you tested these changes with HornetQ clients to ensure there are no regressions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---