You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/10/20 10:13:16 UTC

[PR] [ML][MLLIB][PYTHON] Say deprecated APIs will be removed in the future [spark]

zhengruifeng opened a new pull request, #59638:
URL: https://github.com/apache/spark/pull/59638

   ### What changes were proposed in this pull request?
   
   Rewords deprecation messages that do not match the current state of the code:
   
   - `StringIndexerModel.labels` (`mllib/.../ml/feature/StringIndexer.scala`) said it "will be removed in 3.1.0", a version that has already passed without removal. It now says "will be removed in the future". The matching line in `docs/ml-migration-guide.md` is updated the same way.
   - The Python `mllib` deprecation warnings for `LinearRegressionWithSGD`, `LassoWithSGD`, `RidgeRegressionWithSGD`, and `LogisticRegressionWithSGD` said "Deprecated in 2.0.0" without saying anything about removal. They now say "Deprecated in 2.0.0 and will be removed in the future."
   
   No API is removed or changed. The version-free wording is intentional, since no removal release has been chosen.
   
   ### Why are the changes needed?
   
   A removal version that has passed without any removal misleads users about whether the API still exists and when it will go. Stating "will be removed in the future" describes the actual state.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Only the text of deprecation messages and the migration guide. No API or behavior changes.
   
   ### How was this patch tested?
   
   No tests added. No existing test matches the old message text. `ruff check` and `ruff format --check` pass on the two changed Python files, and the changed lines are within the 100-character limit. The Scala change only edits the string argument of a `@deprecated` annotation.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude (system.ai.claude-haiku-5-5) via Claude Code
   
   This pull request and its description were written by Isaac.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org