[jira] [Comment Edited] (JCRVLT-634) Make sure that vault-cli contains all necessary dependencies

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545890#comment-17545890 ] 

Konrad Windszus edited comment on JCRVLT-634 at 6/3/22 2:24 PM:
----------------------------------------------------------------

Currently errors for the following dependencies are emitted


||Dependency||Via||Relevant at runtime||
|javax.servlet:javax.servlet-api:jar:3.1.0| org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> org.apache.jackrabbit:jackrabbit-spi2dav:jar:2.20.4| |
|org.osgi:org.osgi.compendium:jar:4.1.0|org.apache.jackrabbit.vault:vault-sync:jar:3.6.1-SNAPSHOT -> org.apache.sling:org.apache.sling.commons.osgi:jar:2.0.6| |
|org.osgi:org.osgi.framework:jar:1.8.0|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT| |
|org.apache.commons:commons-lang3:jar:3.6|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> org.apache.maven:maven-artifact:jar:3.8.4| |
|org.slf4j:slf4j-log4j12:jar:1.7.25|org.apache.jackrabbit.vault:vault-vlt:jar:3.6.1-SNAPSHOT| |
|org.osgi:org.osgi.core:jar:4.1.0|org.apache.jackrabbit.vault:vault-sync:jar:3.6.1-SNAPSHOT -> org.apache.sling:org.apache.sling.commons.osgi:jar:2.0.6| |
|org.glassfish.jaxb:txw2:jar:2.3.2|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT| |
|log4j:log4j:jar:1.2.12|org.apache.jackrabbit.vault:vault-vlt:jar:3.6.1-SNAPSHOT||
|org.codehaus.woodstox:stax2-api:jar:4.2|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> com.fasterxml.woodstox:woodstox-core:jar:6.1.1| |
|com.h2database:h2:jar:2.1.212|via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT| |
|org.osgi:org.osgi.service.metatype.annotations:jar:1.3.0|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT| |
|org.codehaus.plexus:plexus-utils:jar:3.3.0 |org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> org.apache.maven:maven-artifact:jar:3.8.4| |
|com.fasterxml.woodstox:woodstox-core:jar:6.1.1|via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT)| |
|org.osgi:org.osgi.annotation.versioning:jar:1.1.0|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT| |
|org.apache.maven:maven-artifact:jar:3.8.4|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT| |
|org.osgi:org.osgi.service.component.annotations:jar:1.4.0|org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT| |
|org.osgi:org.osgi.annotation:jar:6.0.0|org.apache.jackrabbit:jackrabbit-jcr-commons:jar:2.20.4| |



was (Author: kwin):
Currently the following errors are emitted
{code}
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-complete-runtime-classpath) @ vault-cli ---
[WARNING] Rule 0: org.apache.sling.maven.enforcer.RequireTransitiveProvidedDependenciesInRuntimeClasspath failed with message:
Found 17 missing runtime dependencies:
Transitive provided dependency javax.servlet:javax.servlet-api:jar:3.1.0 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> org.apache.jackrabbit:jackrabbit-spi2dav:jar:2.20.4) not found as runtime dependency!
Transitive provided dependency org.osgi:org.osgi.compendium:jar:4.1.0 (via org.apache.jackrabbit.vault:vault-sync:jar:3.6.1-SNAPSHOT -> org.apache.sling:org.apache.sling.commons.osgi:jar:2.0.6) not found as runtime dependency!
Transitive provided dependency org.osgi:org.osgi.framework:jar:1.8.0 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.apache.commons:commons-lang3:jar:3.6 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> org.apache.maven:maven-artifact:jar:3.8.4) not found as runtime dependency!
Transitive provided dependency org.slf4j:slf4j-log4j12:jar:1.7.25 (via org.apache.jackrabbit.vault:vault-vlt:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.osgi:org.osgi.core:jar:4.1.0 (via org.apache.jackrabbit.vault:vault-sync:jar:3.6.1-SNAPSHOT -> org.apache.sling:org.apache.sling.commons.osgi:jar:2.0.6) not found as runtime dependency!
Transitive provided dependency org.glassfish.jaxb:txw2:jar:2.3.2 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency log4j:log4j:jar:1.2.12 (via org.apache.jackrabbit.vault:vault-vlt:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.codehaus.woodstox:stax2-api:jar:4.2 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> com.fasterxml.woodstox:woodstox-core:jar:6.1.1) not found as runtime dependency!
Transitive provided dependency com.h2database:h2:jar:2.1.212 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.osgi:org.osgi.service.metatype.annotations:jar:1.3.0 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.codehaus.plexus:plexus-utils:jar:3.3.0 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT -> org.apache.maven:maven-artifact:jar:3.8.4) not found as runtime dependency!
Transitive provided dependency com.fasterxml.woodstox:woodstox-core:jar:6.1.1 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.osgi:org.osgi.annotation.versioning:jar:1.1.0 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.apache.maven:maven-artifact:jar:3.8.4 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.osgi:org.osgi.service.component.annotations:jar:1.4.0 (via org.apache.jackrabbit.vault:org.apache.jackrabbit.vault:jar:3.6.1-SNAPSHOT) not found as runtime dependency!
Transitive provided dependency org.osgi:org.osgi.annotation:jar:6.0.0 (via org.apache.jackrabbit:jackrabbit-jcr-commons:jar:2.20.4) not found as runtime dependency!
{code}

> Make sure that vault-cli contains all necessary dependencies
> ------------------------------------------------------------
>
>                 Key: JCRVLT-634
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-634
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: vlt
>            Reporter: Konrad Windszus
>            Priority: Major
>
> The appassembler automatically packs up all Maven dependencies with runtime scope. 
> As lots of transitive dependencies have scope "provided" (and are therefore not automatically inherited) the dependencies need to be managed manually to a certain degree.
> To make sure that the runtime dependencies include all necessary dependencies the build should execute the custom Maven Enforcer rule from SLING-11369.
> Some dependencies which are known to be not necessary at runtime need to be excluded from the rule.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)