You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by si...@apache.org on 2022/07/07 01:22:58 UTC
[pinot] branch master updated: adding explicit error on record reader (#9024)
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ebf8a103c0 adding explicit error on record reader (#9024)
ebf8a103c0 is described below
commit ebf8a103c033f55c243486d3df113d41c238743a
Author: Rong Rong <wa...@gmail.com>
AuthorDate: Wed Jul 6 18:22:52 2022 -0700
adding explicit error on record reader (#9024)
* adding explicit error on record reader
* Update pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java
Co-authored-by: Rong Rong <ro...@startree.ai>
---
.../indexsegment/mutable/MutableSegmentImpl.java | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java
index baed54aa10..ea08775c78 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java
@@ -998,14 +998,20 @@ public class MutableSegmentImpl implements MutableSegment {
@Override
public GenericRow getRecord(int docId, GenericRow reuse) {
for (Map.Entry<String, IndexContainer> entry : _indexContainerMap.entrySet()) {
- String column = entry.getKey();
- IndexContainer indexContainer = entry.getValue();
- Object value = getValue(docId, indexContainer._forwardIndex, indexContainer._dictionary,
- indexContainer._numValuesInfo._maxNumValuesPerMVEntry);
- if (_nullHandlingEnabled && indexContainer._nullValueVector.isNull(docId)) {
- reuse.putDefaultNullValue(column, value);
- } else {
- reuse.putValue(column, value);
+ try {
+ String column = entry.getKey();
+ IndexContainer indexContainer = entry.getValue();
+ Object value = getValue(docId, indexContainer._forwardIndex, indexContainer._dictionary,
+ indexContainer._numValuesInfo._maxNumValuesPerMVEntry);
+ if (_nullHandlingEnabled && indexContainer._nullValueVector.isNull(docId)) {
+ reuse.putDefaultNullValue(column, value);
+ } else {
+ reuse.putValue(column, value);
+ }
+ } catch (Exception e) {
+ _logger.error("error encountered when getting record for {} on indexContainer: {}", docId, entry.getKey());
+ throw new RuntimeException("error encountered when getting record for " + docId + " on indexContainer: "
+ + entry.getKey(), e);
}
}
return reuse;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org