You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/03/11 18:51:22 UTC

Review Request 19057: gmetad/gmond left in init after install

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.


Bugs: AMBARI-5031
    https://issues.apache.org/jira/browse/AMBARI-5031


Repository: ambari


Description
-------

Gmond is set to start on boot, so when the server is rebooted our hdp-gmond fails to start. We need to make sure that after we install ganglia we do a : 'chkconfig --del gmond' to make sure the process that does not have our config /etc/init.d/gmond does not start on boot.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 4b825b4 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor_service.py d86d894 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py 32c198e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 6f9bc40 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor_service.py d86d894 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 467336a 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 5127906 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py 4ecb539 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 52aff88 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py f6af9ab 

Diff: https://reviews.apache.org/r/19057/diff/


Testing
-------

----------------------------------------------------------------------
Ran 188 tests in 1.203s

OK
----------------------------------------------------------------------
Total run:507
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi


Re: Review Request 19057: gmetad/gmond left in init after install

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/#review37212
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On March 14, 2014, 4:26 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19057/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 4:26 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5031
>     https://issues.apache.org/jira/browse/AMBARI-5031
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Gmond is set to start on boot, so when the server is rebooted our hdp-gmond fails to start. We need to make sure that after we install ganglia we do a : 'chkconfig --del gmond' to make sure the process that does not have our config /etc/init.d/gmond does not start on boot.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 2eab1e8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py d03f0bb 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py af56453 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 666ac3e 
> 
> Diff: https://reviews.apache.org/r/19057/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 188 tests in 1.203s
> 
> OK
> ----------------------------------------------------------------------
> Total run:507
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 19057: gmetad/gmond left in init after install

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/#review37211
-----------------------------------------------------------

Ship it!


Makes sense that we shutdown both GMOND and GMETAD on all hosts.

- Sumit Mohanty


On March 14, 2014, 4:26 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19057/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 4:26 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5031
>     https://issues.apache.org/jira/browse/AMBARI-5031
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Gmond is set to start on boot, so when the server is rebooted our hdp-gmond fails to start. We need to make sure that after we install ganglia we do a : 'chkconfig --del gmond' to make sure the process that does not have our config /etc/init.d/gmond does not start on boot.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 2eab1e8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py d03f0bb 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py af56453 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 666ac3e 
> 
> Diff: https://reviews.apache.org/r/19057/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 188 tests in 1.203s
> 
> OK
> ----------------------------------------------------------------------
> Total run:507
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 19057: gmetad/gmond left in init after install

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/
-----------------------------------------------------------

(Updated March 14, 2014, 4:26 p.m.)


Review request for Ambari, Dmytro Sen and Sumit Mohanty.


Bugs: AMBARI-5031
    https://issues.apache.org/jira/browse/AMBARI-5031


Repository: ambari


Description
-------

Gmond is set to start on boot, so when the server is rebooted our hdp-gmond fails to start. We need to make sure that after we install ganglia we do a : 'chkconfig --del gmond' to make sure the process that does not have our config /etc/init.d/gmond does not start on boot.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 2eab1e8 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py d03f0bb 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py af56453 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 666ac3e 

Diff: https://reviews.apache.org/r/19057/diff/


Testing
-------

----------------------------------------------------------------------
Ran 188 tests in 1.203s

OK
----------------------------------------------------------------------
Total run:507
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi


Re: Review Request 19057: gmetad/gmond left in init after install

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/
-----------------------------------------------------------

(Updated March 14, 2014, 4:25 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.


Changes
-------

I've missed that we are installing gmetad on hosts where we need only gmond too.


Bugs: AMBARI-5031
    https://issues.apache.org/jira/browse/AMBARI-5031


Repository: ambari


Description
-------

Gmond is set to start on boot, so when the server is rebooted our hdp-gmond fails to start. We need to make sure that after we install ganglia we do a : 'chkconfig --del gmond' to make sure the process that does not have our config /etc/init.d/gmond does not start on boot.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 2eab1e8 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py d03f0bb 
  ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py af56453 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 666ac3e 

Diff: https://reviews.apache.org/r/19057/diff/


Testing
-------

----------------------------------------------------------------------
Ran 188 tests in 1.203s

OK
----------------------------------------------------------------------
Total run:507
Total errors:0
Total failures:0
OK


Thanks,

Vitalyi Brodetskyi


Re: Review Request 19057: gmetad/gmond left in init after install

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/#review36816
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On March 11, 2014, 5:51 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19057/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 5:51 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5031
>     https://issues.apache.org/jira/browse/AMBARI-5031
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Gmond is set to start on boot, so when the server is rebooted our hdp-gmond fails to start. We need to make sure that after we install ganglia we do a : 'chkconfig --del gmond' to make sure the process that does not have our config /etc/init.d/gmond does not start on boot.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 4b825b4 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor_service.py d86d894 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py 32c198e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 6f9bc40 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor_service.py d86d894 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 467336a 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 5127906 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py 4ecb539 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 52aff88 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py f6af9ab 
> 
> Diff: https://reviews.apache.org/r/19057/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 188 tests in 1.203s
> 
> OK
> ----------------------------------------------------------------------
> Total run:507
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 19057: gmetad/gmond left in init after install

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19057/#review36811
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 11, 2014, 5:51 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19057/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 5:51 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5031
>     https://issues.apache.org/jira/browse/AMBARI-5031
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Gmond is set to start on boot, so when the server is rebooted our hdp-gmond fails to start. We need to make sure that after we install ganglia we do a : 'chkconfig --del gmond' to make sure the process that does not have our config /etc/init.d/gmond does not start on boot.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor.py 4b825b4 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_monitor_service.py d86d894 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/ganglia_server.py 32c198e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 6f9bc40 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor_service.py d86d894 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 467336a 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_monitor.py 5127906 
>   ambari-server/src/test/python/stacks/1.3.2/GANGLIA/test_ganglia_server.py 4ecb539 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 52aff88 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py f6af9ab 
> 
> Diff: https://reviews.apache.org/r/19057/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 188 tests in 1.203s
> 
> OK
> ----------------------------------------------------------------------
> Total run:507
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>