You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/03/25 13:13:40 UTC
[GitHub] [servicecomb-java-chassis] kaister3 opened a new pull request #2317: [SCB2224] BeanUtils.getBeanOfType return null when aksk enabled
kaister3 opened a new pull request #2317:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] kaister3 commented on a change in pull request #2317: [SCB-2224] BeanUtils.getBeanOfType return null when aksk enabled
Posted by GitBox <gi...@apache.org>.
kaister3 commented on a change in pull request #2317:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2317#discussion_r601966320
##########
File path: huawei-cloud/servicestage/src/main/java/org/apache/servicecomb/huaweicloud/servicestage/AKSKAuthHeaderProvider.java
##########
@@ -142,8 +144,8 @@ private Cipher findCipher() {
return DefaultCipher.getInstance();
}
- Map<String, Cipher> cipherBeans = BeanUtils.getBeansOfType(Cipher.class);
- return cipherBeans.values().stream().filter(c -> c.name().equals(getCipher())).findFirst()
+ List<Cipher> ciphers = SPIServiceUtils.getOrLoadSortedService(Cipher.class);
Review comment:
SPI definition file is added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2317: [SCB-2224] BeanUtils.getBeanOfType return null when aksk enabled
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2317:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2317: [SCB2224] BeanUtils.getBeanOfType return null when aksk enabled
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2317:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2317#discussion_r601956542
##########
File path: huawei-cloud/servicestage/src/main/java/org/apache/servicecomb/huaweicloud/servicestage/AKSKAuthHeaderProvider.java
##########
@@ -142,8 +144,8 @@ private Cipher findCipher() {
return DefaultCipher.getInstance();
}
- Map<String, Cipher> cipherBeans = BeanUtils.getBeansOfType(Cipher.class);
- return cipherBeans.values().stream().filter(c -> c.name().equals(getCipher())).findFirst()
+ List<Cipher> ciphers = SPIServiceUtils.getOrLoadSortedService(Cipher.class);
Review comment:
Missed SPI definition file for AKSKCIpher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org