You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2024/03/14 16:03:30 UTC
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
j_anshula@yahoo.in has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21147
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised
ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/1
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21147
to look at the new patch set (#2).
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised
ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/2
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
If NUM_NODES is set to a value other than 0 or 1 below error is raised
ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
M tests/hs2/test_hs2.py
3 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/6
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 6
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
j_anshula@yahoo.in has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised
ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/4
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15563/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 18:11:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
Patch Set 4:
(5 comments)
Looks good. Just few style nits to edit.
http://gerrit.cloudera.org:8080/#/c/21147/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21147/4//COMMIT_MSG@7
PS4, Line 7: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised
: ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
nit: Use short title and separate the title with the rest of commit message with an empty line. I recommend to change it like this:
IMPALA-11938: Raise error if NUM_NODES is set to invalid value.
If NUM_NODES is set to a value other than 0 or 1 below error is raised:
ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc
File be/src/service/query-options-test.cc:
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc@273
PS4, Line 273: {
nit: align the open curly brace with the one in L266
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options-test.cc@274
PS4, Line 274: };
nit: keep this L274 the same as the original.
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc
File be/src/service/query-options.cc:
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246
PS4, Line 246: option, value, 0, 1, &int32_t_val));
> line has trailing whitespace
nit: Please remove the trailing whitespace.
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246
PS4, Line 246: option
nit: add 4 spaces indentation before 'option'.
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:45:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 7
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 15:45:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 7
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 20:42:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc
File be/src/service/query-options.cc:
http://gerrit.cloudera.org:8080/#/c/21147/4/be/src/service/query-options.cc@246
PS4, Line 246: option, value, 0, 1, &int32_t_val));
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:29:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
Patch Set 2:
Thank you for fixing this.
Please also add test in QueryOptions.SetIntOptions. Adding the following line in case_set should do it.
{MAKE_OPTIONDEF(num_nodes), {0, 1}},
https://github.com/apache/impala/blob/691604b1d1f0e5f0dc95fdb4976cf826135e08fb/be/src/service/query-options-test.cc#L247-L248
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2024 16:19:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
j_anshula@yahoo.in has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 5:
> Uploaded patch set 5.
Made the changes as suggested
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 17:48:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15509/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2024 16:26:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 17:59:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10383/
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 5
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 22:45:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15580/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 6
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 13:01:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
If NUM_NODES is set to a value other than 0 or 1 below error is raised
ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Reviewed-on: http://gerrit.cloudera.org:8080/21147
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
M tests/hs2/test_hs2.py
3 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 8
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 6
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 15:44:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10396/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 7
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 15:45:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15560/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:52:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
j_anshula@yahoo.in has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
If NUM_NODES is set to a value other than 0 or 1 below error is raised
ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/21147/5
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10383/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 18:00:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: Raised error if NUM NODES is set to invalid value.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: Raised error if NUM_NODES is set to invalid value.
......................................................................
Patch Set 5: -Code-Review
> Patch Set 5: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10383/
TestHS2.test_open_session_query_options failed here.
The value of NUM_NODES in this test should be changed from 1234 to, say, 1.
https://github.com/apache/impala/blob/711a9f2bad84f92dc4af61d49ae115f0dc4239da/tests/hs2/test_hs2.py#L75
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 5
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Mar 2024 22:50:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11938: If NUM NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM NODES: is not in range [0, 1]
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21147 )
Change subject: IMPALA-11938: If NUM_NODES is set to a value other than 0 or 1 below error is raised ERROR: Invalid value for query option NUM_NODES: <value> is not in range [0, 1]
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21147/1/be/src/service/query-options.cc
File be/src/service/query-options.cc:
http://gerrit.cloudera.org:8080/#/c/21147/1/be/src/service/query-options.cc@246
PS1, Line 246: option, value, 0, 1, &int32_t_val));
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib283ae350875a7ac217490c216a26281f1bb4812
Gerrit-Change-Number: 21147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Mar 2024 16:04:33 +0000
Gerrit-HasComments: Yes