You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/09 23:12:36 UTC
[GitHub] [superset] eschutho opened a new pull request #16156: feat: add config to hide some user menu items
eschutho opened a new pull request #16156:
URL: https://github.com/apache/superset/pull/16156
### SUMMARY
Adding a config flag that allows admins to hide some menu items for users.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
<img width="374" alt="_DEV__Superset" src="https://user-images.githubusercontent.com/5186919/128785421-13d07139-2759-4a83-afca-955d3391c5a2.png">
### TESTING INSTRUCTIONS
Add flag to config and test that the menu items are gone. With the flag the menu items should be there and the links should still work.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho merged pull request #16156: feat: add config to hide some user menu items
Posted by GitBox <gi...@apache.org>.
eschutho merged pull request #16156:
URL: https://github.com/apache/superset/pull/16156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu commented on pull request #16156: feat: add config to hide some user menu items
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu commented on pull request #16156:
URL: https://github.com/apache/superset/pull/16156#issuecomment-896125441
🏷 2021.31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #16156: feat: add config to hide some user menu items
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #16156:
URL: https://github.com/apache/superset/pull/16156#discussion_r685580916
##########
File path: superset/templates/appbuilder/navbar_right.html
##########
@@ -1,67 +1,67 @@
-{#
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-#}
-
-{% set bug_report_url = appbuilder.app.config['BUG_REPORT_URL'] %}
-{% set documentation_url = appbuilder.app.config['DOCUMENTATION_URL'] %}
-{% set documentation_text = appbuilder.app.config['DOCUMENTATION_TEXT'] %}
-{% set documentation_icon = appbuilder.app.config['DOCUMENTATION_ICON'] %}
-{% set version_string = appbuilder.app.config['VERSION_STRING'] %}
-{% set version_sha = appbuilder.app.config['VERSION_SHA'] %}
-
-{% set locale = session['locale'] %}
-{% if not locale %}
- {% set locale = 'en' %}
-{% endif %}
-
-{% if not current_user.is_anonymous %}
- <li class="dropdown">
- <button type="button" style="margin-top: 12px; margin-right: 30px;" data-toggle="dropdown" class="dropdown-toggle btn btn-sm btn-primary">
- <i class="fa fa-plus"></i> {{ _("New") }}
- </button>
- <ul class="dropdown-menu">
- <li><a href="/superset/sqllab"><span class="fa fa-fw fa-search"></span> {{_("SQL Query")}}</a></li>
- <li><a href="/chart/add"><span class="fa fa-fw fa-bar-chart"></span> {{_("Chart")}}</a></li>
- <li><a href="/dashboard/new/"><span class="fa fa-fw fa-dashboard"></span> {{_("Dashboard")}}</a></li>
- </ul>
+{# Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with this work
+for additional information regarding copyright ownership. The ASF licenses this
+file to you under the Apache License, Version 2.0 (the "License"); you may not
+use this file except in compliance with the License. You may obtain a copy of
+the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by
+applicable law or agreed to in writing, software distributed under the License
+is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the specific language
+governing permissions and limitations under the License. #} {% set
+bug_report_url = appbuilder.app.config['BUG_REPORT_URL'] %} {% set
+documentation_url = appbuilder.app.config['DOCUMENTATION_URL'] %} {% set
+documentation_text = appbuilder.app.config['DOCUMENTATION_TEXT'] %} {% set
+documentation_icon = appbuilder.app.config['DOCUMENTATION_ICON'] %} {% set
+version_string = appbuilder.app.config['VERSION_STRING'] %} {% set version_sha =
+appbuilder.app.config['VERSION_SHA'] %} {% set locale = session['locale'] %} {%
+if not locale %} {% set locale = 'en' %} {% endif %} {% if not
+current_user.is_anonymous %}
+<li class="dropdown">
Review comment:
prettier seems to think that this is the correct format. :>/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #16156: feat: add config to hide some user menu items
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #16156:
URL: https://github.com/apache/superset/pull/16156#discussion_r685580916
##########
File path: superset/templates/appbuilder/navbar_right.html
##########
@@ -1,67 +1,67 @@
-{#
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-#}
-
-{% set bug_report_url = appbuilder.app.config['BUG_REPORT_URL'] %}
-{% set documentation_url = appbuilder.app.config['DOCUMENTATION_URL'] %}
-{% set documentation_text = appbuilder.app.config['DOCUMENTATION_TEXT'] %}
-{% set documentation_icon = appbuilder.app.config['DOCUMENTATION_ICON'] %}
-{% set version_string = appbuilder.app.config['VERSION_STRING'] %}
-{% set version_sha = appbuilder.app.config['VERSION_SHA'] %}
-
-{% set locale = session['locale'] %}
-{% if not locale %}
- {% set locale = 'en' %}
-{% endif %}
-
-{% if not current_user.is_anonymous %}
- <li class="dropdown">
- <button type="button" style="margin-top: 12px; margin-right: 30px;" data-toggle="dropdown" class="dropdown-toggle btn btn-sm btn-primary">
- <i class="fa fa-plus"></i> {{ _("New") }}
- </button>
- <ul class="dropdown-menu">
- <li><a href="/superset/sqllab"><span class="fa fa-fw fa-search"></span> {{_("SQL Query")}}</a></li>
- <li><a href="/chart/add"><span class="fa fa-fw fa-bar-chart"></span> {{_("Chart")}}</a></li>
- <li><a href="/dashboard/new/"><span class="fa fa-fw fa-dashboard"></span> {{_("Dashboard")}}</a></li>
- </ul>
+{# Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with this work
+for additional information regarding copyright ownership. The ASF licenses this
+file to you under the Apache License, Version 2.0 (the "License"); you may not
+use this file except in compliance with the License. You may obtain a copy of
+the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by
+applicable law or agreed to in writing, software distributed under the License
+is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the specific language
+governing permissions and limitations under the License. #} {% set
+bug_report_url = appbuilder.app.config['BUG_REPORT_URL'] %} {% set
+documentation_url = appbuilder.app.config['DOCUMENTATION_URL'] %} {% set
+documentation_text = appbuilder.app.config['DOCUMENTATION_TEXT'] %} {% set
+documentation_icon = appbuilder.app.config['DOCUMENTATION_ICON'] %} {% set
+version_string = appbuilder.app.config['VERSION_STRING'] %} {% set version_sha =
+appbuilder.app.config['VERSION_SHA'] %} {% set locale = session['locale'] %} {%
+if not locale %} {% set locale = 'en' %} {% endif %} {% if not
+current_user.is_anonymous %}
+<li class="dropdown">
Review comment:
prettier seems to think that this is the correct format. :>/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org