You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/02 02:21:17 UTC

[GitHub] [kafka] hachikuji commented on a diff in pull request #12847: KAFKA-14367; Add `SyncGroup` to the new `GroupCoordinator` interface

hachikuji commented on code in PR #12847:
URL: https://github.com/apache/kafka/pull/12847#discussion_r1037728116


##########
core/src/main/scala/kafka/server/RequestHandlerHelper.scala:
##########
@@ -107,6 +107,18 @@ class RequestHandlerHelper(
 
   // Throttle the channel if the request quota is enabled but has been violated. Regardless of throttling, send the
   // response immediately.
+  def sendResponse(

Review Comment:
   How about `sendMaybeThrottle` or `sendAndMaybeThrottle`? I think including "Response" is redundant given the parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org