You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Michael Elman (JIRA)" <ji...@apache.org> on 2009/09/22 07:28:16 UTC

[jira] Reopened: (WINK-142) Provider support for Jettison

     [ https://issues.apache.org/jira/browse/WINK-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Elman reopened WINK-142:
--------------------------------


I took a look at Jettison providers. Some thoughts:

1. I think that default constructor should use BadgerFish convention. Meaning:
{code}
    public JettisonJAXBElementProvider() {
        this(true, null, null);
    }
{code}
Using a default constructor as is will always cause an exception.

2. For BadgerFish convention the else statements are redundant, since neither input nor output configuration is used.
{code}
 if (reader != null) {
            this.inputConfiguration = reader;
        } else {
            this.inputConfiguration = new Configuration(new HashMap<String, String>());
        }
        if (writer != null) {
            this.outputConfiguration = writer;
        } else {
            this.outputConfiguration = new Configuration(new HashMap<String, String>());
        }
{code}

3. It would be nice to add META-INF/wink-application to this module.

I'll reopen the issue for now. Feel free to close, if you think that this issues should not be resolved, or be part of a different issue.

> Provider support for Jettison
> -----------------------------
>
>                 Key: WINK-142
>                 URL: https://issues.apache.org/jira/browse/WINK-142
>             Project: Wink
>          Issue Type: New Feature
>          Components: Common
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.2
>
>
> Jettison (http://jettison.codehaus.org/) is a well known JSON StAX implementation.  It would be nice to have it as a provider that can be easily enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.