You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/07/04 14:46:12 UTC

[GitHub] flink issue #6253: [WIP][FLINK-8094][Table API & SQL] Support other types fo...

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/flink/pull/6253
  
    Seeking for some guides on this PR:
    
    1. Maybe we could replace the implementation of ExistingField with the implementation of IsoDateStringAwareExistingField since the implementation is on top of ExistingField. Would we think replacing is better?
    
    2. ExistingField has no test so I also don't add test for IsoDateStringAwareExistingField: I guess adding test might require more understanding of Table API. Would it be OK to skip adding test for IsoDateStringAwareExistingField?
    
    cc. @fhueske


---