You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2016/11/07 22:29:59 UTC
[jira] [Commented] (HIVE-14908) Upgrade ANTLR to 3.5.2
[ https://issues.apache.org/jira/browse/HIVE-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645671#comment-15645671 ]
Hive QA commented on HIVE-14908:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12837820/HIVE-14908.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10628 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid] (batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=145)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_5] (batchId=90)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[columnstats_partlvl_multiple_part_clause] (batchId=83)
org.apache.hadoop.hive.ql.parse.TestParseNegativeDriver.testCliDriver[missing_overwrite] (batchId=223)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2009/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2009/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2009/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12837820 - PreCommit-HIVE-Build
> Upgrade ANTLR to 3.5.2
> ----------------------
>
> Key: HIVE-14908
> URL: https://issues.apache.org/jira/browse/HIVE-14908
> Project: Hive
> Issue Type: Sub-task
> Reporter: Pengcheng Xiong
> Assignee: Pengcheng Xiong
> Attachments: HIVE-14908.01.patch, HIVE-14908.02.patch
>
>
> Antlr v4 is also available but it does not support "->" which is widely used in our grammar. Antlr 3.5.2 is the latest v3 version. It will reduce the code size:
> {code}
> Here is summary of current parser code size
> 422345 HiveLexer.java
> 2436601 HiveParser.java
> 814184 HiveParser_FromClauseParser.java
> 2705920 HiveParser_IdentifiersParser.java
> 777665 HiveParser_SelectClauseParser.java
> After change, it will become
> 319589 HiveLexer.java
> 1853104 HiveParser.java
> 574156 HiveParser_FromClauseParser.java
> 1799195 HiveParser_IdentifiersParser.java
> 587305 HiveParser_SelectClauseParser.java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)